Add try..except block in pre-commit linter (oppia#6019)

* Add try..except block in pre-commit linter Add try..except block to handle the case when there are no Python, JavaScript or CSS files to lint. * Modify comment * Move comment inside the try..except block
quantumferret · Dec 21, 2018 · 8a58279 · 8a58279
1 parent f760bd8
commit 8a58279
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/scripts/pre_commit_linter.py b/scripts/pre_commit_linter.py
@@ -737,10 +737,15 @@ def _pre_commit_linter(all_files):
 
     TIMEOUT_MULTIPLIER = 1000
     for file_group, process in zip(file_groups_to_lint, linting_processes):
-        # Require timeout parameter to prevent against endless waiting for the
-        # linting function to return.
-        process.join(timeout=(
-            TIMEOUT_MULTIPLIER * len(file_group) / number_of_files_to_lint))
+        # try..except block is needed to catch ZeroDivisionError
+        # when there are no CSS, HTML, JavaScript and Python files to lint.
+        try:
+            # Require timeout parameter to prevent against endless
+            # waiting for the linting function to return.
+            process.join(timeout=(
+                TIMEOUT_MULTIPLIER * len(file_group) / number_of_files_to_lint))
+        except ZeroDivisionError:
+            break
 
     js_messages = []
     while not js_stdout.empty():