More benchmark fixes #2762
Merged
More benchmark fixes #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
reviewed
Aug 23, 2020
tests/test_examples.py
Outdated
| if benchmark_returns is not None: | ||
| expected_perf = self.expected_perf[example_name] | ||
| else: | ||
| # With no benchmark, expect zero results for these metrics: |
There was a problem hiding this comment.
should we precompute this in the init like self.no_benchmark_expected_perf?
llllllllll
reviewed
Aug 23, 2020
| @@ -513,7 +515,8 @@ def resolve(self, asset_finder, start_date, end_date): | |||
| benchmark_returns = None | |||
| except SymbolNotFound: | |||
| raise _RunAlgoError( | |||
| "Symbol %s as a benchmark not found in this bundle." | |||
| "Symbol %r as a benchmark not found in this bundle." | |||
| % self.benchmark_symbol | |||
|
lgtm |
richafrank
force-pushed
the
more-benchmark-fixes
branch
from
90d4fb7 to
94841eb
Compare
|
Given this is such a common-use case I would suggest this probably warrants a v1.41 release? It's certainly been a common topic from our user base. |
👍 I was thinking the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2761 and adds the docstring missing in #2627 (comment).