Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve python code quality by passing it through automated tools #330

Open
fgeorgatos opened this issue Oct 14, 2024 · 4 comments

Comments

@fgeorgatos
Copy link
Collaborator

QA: The code of qtop has already been through ruff (in a configuration which is now part of the git tree), however there are more things to check and aspects of the code waiting to be improved, without necessarily changing its functionality.

A project of its own is to try the qtop repository against different online tools and see what they report and how (and how easy are the fixes involved). At least of these should be adopted for a day-to-day usage.

The way to go about it is:

@SumirSeth
Copy link

Hello! How do i contribute to this? I have tried forking the repo and feeding it against deepsource. I see a lot of suggested fixes. How do i go forward now? Thank you!

@fgeorgatos
Copy link
Collaborator Author

@SumirSeth thanks for tackling this! Yes, I have seen the same with deepsource; different tools give different suggestions.

No need to fix them yet: let's just iterate the checks through the different tools (in separate repos, to do the comparison).
I have already seen that if you do one of them the others are quite similar (use different repo names or project names)

I propose to review them together, if would like to do that or, find some other procedure which is mutually convenient.

If you could share the URLs to review together here in this issue, that would be the next step.

@fgeorgatos
Copy link
Collaborator Author

@SumirSeth : would you like to select a couple of potential PRs from deepsource? do you see any unavoidable changes?

@SumirSeth
Copy link

@SumirSeth : would you like to select a couple of potential PRs from deepsource? do you see any unavoidable changes?

sorry, been extremely busy with uni. will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants