Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job name has an ampersand in it #303

Open
stetner opened this issue Aug 7, 2017 · 11 comments
Open

Job name has an ampersand in it #303

stetner opened this issue Aug 7, 2017 · 11 comments

Comments

@stetner
Copy link

stetner commented Aug 7, 2017

v0.9.20161222

CRITICAL - Line:
807140.delta      Lambda&S10       haotian.teng      22:41:42 R gpu

not properly parsed by regex expression. Unexpected character.

@stetner
Copy link
Author

stetner commented Aug 7, 2017

qtop_py/plugins/pbs.py

16c16
<                              r'(?P<name>[\w&@%:.=+/{}-]+)\s+' \
---
>                              r'(?P<name>[\w@%:.=+/{}-]+)\s+' \

@sfranky
Copy link
Collaborator

sfranky commented Aug 27, 2017

added in latest experimental branch

@fgeorgatos
Copy link
Collaborator

hi @stetner : I think @sfranky just implies that you should try about it https://github.com/qtop/qtop/tree/develop

your feedback?!

@fgeorgatos
Copy link
Collaborator

or, perhaps, this one is being referred (not sure which one, because I see no relevant PR on it yet):
https://github.com/qtop/qtop/tree/poolMappings

@stetner
Copy link
Author

stetner commented Aug 29, 2017

Looks good in that version!

Thanks
Doug

@stetner
Copy link
Author

stetner commented Aug 30, 2017

Sigh - users.....

Now I have a name with a hash in it.....

Aug_#_100

Can we add # to the regex

Thanks

@eddedmondson
Copy link

I've got a $... is there a better way? What characters are known to not be valid?

@sfranky
Copy link
Collaborator

sfranky commented Aug 30, 2017 via email

@fgeorgatos
Copy link
Collaborator

@sfranky : i'd say don't be far too liberal yet: we'll tackle this right when we'll go for internationalization ...

@stetner
Copy link
Author

stetner commented Dec 19, 2017

Just hit another one...

added a '-' to the user search to match a username like a.smith-brown

    self.user_q_search = r'^(?P<host_name>(?P<job_id>[0-9\[\]-]+)\.(?P<domain>[\w-]+))\s+' \
                         r'(?P<name>[\w#&@%:.=+/{}-]+)\s+' \
                         r'(?P<user>[A-Za-z0-9.-]+)\s+' \
                         r'(?P<time>\d+:\d+:?\d*|0)\s+' \
                         r'(?P<state>[BCEFHMQRSTUWX])\s+' \
                         r'(?P<queue_name>\w+)'

@stetner
Copy link
Author

stetner commented Jan 11, 2018

Hit another one - probably a muser error but PBSPro seems to accept it:

1507877.delta compile_sim_${h i.xxxxxx 0 H normal

So looks like $ and { can be in there too :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants