Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qmk doctor os check to support newer msys2/w10 installations #8031

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Qmk doctor os check to support newer msys2/w10 installations #8031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a85d11
Fixed OS detection on newer MSYS installations
Duckle29 Jan 28, 2020
3649080
made OS sting lower case
Duckle29 Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
made OS sting lower case
  • Loading branch information
@Duckle29
Duckle29 committed Jan 28, 2020
commit 3649080fdfb64ab261957e46748048c282ef5396
8 changes: 4 additions & 4 deletions lib/python/qmk/cli/doctor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ def doctor(cli):
ok = True

# Determine our OS and run platform specific tests
OS = platform.platform() # noqa (N806), uppercase name is ok in this instance
OS = platform.platform().lower() # noqa (N806), uppercase name is ok in this instance

if 'Darwin' in OS:
if 'darwin' in OS:
if not os_test_macos():
ok = False
elif 'Linux' in OS:
elif 'linux' in OS:
if not os_test_linux():
ok = False
elif 'Windows' in OS:
elif 'windows' in OS:
if not os_test_windows():
ok = False
else:
Expand Down