Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qmk doctor os check to support newer msys2/w10 installations #8031

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Qmk doctor os check to support newer msys2/w10 installations #8031

merged 2 commits into from
Jan 28, 2020

Conversation

Duckle29
Copy link
Contributor

Description

I noticed in a fresh MSYS2 installation on a fresh W10 (home and pro) installation didn't work with qmk doctor anymore, as the platform string has changed to indicate that it's msys

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia added bug cli qmk cli command python labels Jan 28, 2020
@Erovia Erovia merged commit 197a401 into qmk:master Jan 28, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 12, 2020
@Duckle29 @drashna
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
48cbd6a 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
@drashna drashna mentioned this pull request Feb 12, 2020
Merged
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 14, 2020
@Duckle29 @fdidron
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
bceaa82 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Duckle29 @HokieGeek
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
5e916c1 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 26, 2020
@Duckle29 @fdidron
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
b1f1010 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@Duckle29 @c0psrul3
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
f31f78f 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Duckle29 @kujawakk
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
68e2005 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Duckle29 @Erovia
Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
31f4f4e 
* Fixed OS detection on newer MSYS installations

* made OS sting lower case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Duckle29 @Erovia