Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/rgb matrix #5811

Merged
merged 7 commits into from
May 10, 2019
Merged

Cleanup/rgb matrix #5811

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c19da05
clean up rgb matrix extern usage
XScorpion2 May 8, 2019
b199562
Fixing the reversed frame buffer access in digital rain
XScorpion2 May 8, 2019
4f9527b
Fixing digital rain & typing heatmap if keyreactive effects are not e…
XScorpion2 May 8, 2019
f4b50ec
Apply suggestions from code review
XScorpion2 May 9, 2019
a1c441c
Adding parenthesizes to DRIVER_LED_TOTAL where necessary
XScorpion2 May 9, 2019
5c5295a
Updated docs
XScorpion2 May 9, 2019
a751eef
added notes about parentheses
XScorpion2 May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added notes about parentheses
  • Loading branch information
@XScorpion2
XScorpion2 committed May 9, 2019
commit a751eefe16ccdc5dcbec1aa1a26d49b9d9b2bcea
2 changes: 2 additions & 0 deletions docs/feature_rgb_matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ Configure the hardware via your `config.h`:
#define DRIVER_LED_TOTAL (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)
```

!> Note the parentheses, this is so when `DRIVER_LED_TOTAL` is used in code and expanded, the values are added together before any additional math is applied to them. As an example, `rand() % (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)` will give very different results than `rand() % DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL`.

Currently only 2 drivers are supported, but it would be trivial to support all 4 combinations.

Define these arrays listing all the LEDs in your `<keyboard>.c`:
Expand Down