There seem to be a few broken layouts, including community ones.

• drashna
  • error: ‘PORTE’ undeclared
  • Due to port not existing on atmega32a
• fun40
  • missing KEY_LOCK_ENABLE = yes rules.mk flags
• krusli
  • error: ‘_NUMPAD’ undeclared here
    • seems broken during JJ40 Refactor and Configurator support #3197
• waples
  • unused variable cie_lightness

Mostly simple fixes, but wont be fixed given the current stance on keymaps. (fun40 is not clear it has an owner)

@zvecr in the future, feel free to tag the owners of these keymaps. That way stuff can git fixed.

@jackhumbert @skullydazed, any issues with the backlight pin addition?

@zvecr,

The drashna keymap is, well, @drashna's, and as I recall, he doesn't own a JJ40.

The fun40 keymap seems to have confusing providence. I think perhaps the user who contributed it deleted their GitHub account, and then someone else (or maybe the same person?) registered the same username. (The PR pre-dates the account creation.)

The issues with the krusli keymap (@krusli) do indeed seem to be my fault. I distinctly remember having a reason for that change, but heck if I can remember what it was. :(

The waples keymap was submitted by... @Waples.

@drashna,

That way stuff can git fixed.

😆

- @noroadsleft
has made similar typos on occasion

@noroadsleft correct. I don't. I do own several 4x12 ortho boards, and am using the community layout. I've fixed the issue in a branch, so it shouldn't trigger the issue in the future.

And yeah, I type git so much, "get" ends up "git" too often. And I figured it was too good to fix here. :D

@noroadsleft _NUMPAD was a holdover from when I was trying a numpad layer on my jj40. I’ve also since moved to having all my ortho boards share the same layout (community layouts) too.

Let me go have a look if I don’t have anything I need, or jj40 specific left in there — if so then it should be fine to just take my keymap out of the jj40 dir.

Thanks!