Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor and product arguments to atmega32a_program.py #5219

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 22, 2019

Description

To allow something like #5206, where a board which uses atmega32a_program.py wants to use a unique VENDOR_ID and PRODUCT_ID. The programming script has hard coded values, which will cause problems if the target board is not in the bootloader. This PR allows the values to be passed, for example:

./utils/atmega32a_program.py --vendor=0x4B52 --product=0x422D kprepublic_jj40_default.hex

Defaults maintain the previous behaviour.

While changing the script, i also got rid of a few pylint warnings.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr mentioned this pull request Feb 26, 2019
13 tasks
@skullydazed skullydazed merged commit 6832a06 into qmk:master Apr 12, 2019
@skullydazed
Copy link
Member

Thanks!

@zvecr zvecr deleted the feature/atmega32a_program_args branch April 28, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants