Add vendor and product arguments to atmega32a_program.py #5219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To allow something like #5206, where a board which uses
atmega32a_program.py
wants to use a unique VENDOR_ID and PRODUCT_ID. The programming script has hard coded values, which will cause problems if the target board is not in the bootloader. This PR allows the values to be passed, for example:Defaults maintain the previous behaviour.
While changing the script, i also got rid of a few pylint warnings.
Types of Changes
Checklist