Add files for h87a PCB #3329
Add files for h87a PCB #3329
Conversation
keyboards/h87a/Makefile
Outdated
| @@ -0,0 +1,3 @@ | |||
| ifndef MAKEFILE_INCLUDED | |||
There was a problem hiding this comment.
Please remove this file.
It's out dated, and no longer needed.
keyboards/h87a/config.h
Outdated
| #ifndef CONFIG_H | ||
| #define CONFIG_H | ||
|
|
||
| #include "config_common.h" |
There was a problem hiding this comment.
This include isn't needed, I believe.
There was a problem hiding this comment.
looks like I need at least
#define CONFIG_H
#include "config_common.h"
in there. The #ifdef and #endif at the end of the sequence were removed and it passed.
keyboards/h87a/rules.mk
Outdated
|
|
||
|
|
||
| # Boot Section Size in *bytes* | ||
| OPT_DEFS += -DBOOTLOADER_SIZE=4096 |
There was a problem hiding this comment.
Is this a Pro Micro, or Teensy, or a SMD MCU?
keyboards/h87a/rules.mk
Outdated
| # Build Options | ||
| # comment out to disable the options. | ||
| # | ||
| BOOTMAGIC_ENABLE ?= yes # Virtual DIP switch configuration(+1000) |
There was a problem hiding this comment.
Could you remove the question marks here, they are not needed.
keyboards/h87a/readme.md
Outdated
|
|
||
| A QMK-powered replacement PCB for custom TKL keyboards. This PCB has the same size of the b.87 PCB, while using the USB port placement and spacebar stabilizer orientation as the a.87 PCB. | ||
|
|
||
| Keyboard Maintainer: hineybush (Josh Hinnebusch) |
There was a problem hiding this comment.
Make sure that each of these lines has two spaces on them.
There was a problem hiding this comment.
For the keyboard maintainer and the next two lines, make sure that each of these has 2 spaces at the end of the line. Otherwise, it's not formatted correctly.
keyboards/h87a/readme.md
Outdated
|
|
||
| Make example for this keyboard (after setting up your build environment): | ||
|
|
||
| make h87a default |
There was a problem hiding this comment.
This should be make h87a:default
keyboards/h87a/h87a.h
Outdated
|
|
||
| #include "quantum.h" | ||
|
|
||
| #define KEYMAP( \ |
There was a problem hiding this comment.
This matrix needs to be fixed. It's "wrong".
Give me a bit and I'll fix it, or somebody else will.
There was a problem hiding this comment.
Also, the KEYMAP should be changed to LAYOUT, or even a specific layout.
| @@ -0,0 +1,5 @@ | |||
| [.ShellClassInfo] | |||
| @@ -0,0 +1,39 @@ | |||
| #include "h87a.h" | |||
There was a problem hiding this comment.
This should be replaced with #include QMK_KEYBOARD_H
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| KEYMAP( |
There was a problem hiding this comment.
This should be changed to LAYOUT, and needs to be fixed, as well (see the comment on the h file)
Add "define CONFIG_H and include "config_common.h" back to file
|
Thanks! |
* Add H87a keymap and info * Create readme.md * Add h87a .json for kbfirmware.com use * Update readme.md * Update readme.md * Update h87a files * Delete Makefile * Update readme.md * Delete desktop.ini * update files to match new QMK framework * Update files to match new QMK structure * Update files to match new QMK structure * add layout name information * Add info.json * update keymap to support layout_all * update keymap to support layout_all * update rules.mk to fix filesize * Update readme.md * Update config.h * Update readme.md * Update config.h * Update config.h Add "define CONFIG_H and include "config_common.h" back to file
* Add H87a keymap and info * Create readme.md * Add h87a .json for kbfirmware.com use * Update readme.md * Update readme.md * Update h87a files * Delete Makefile * Update readme.md * Delete desktop.ini * update files to match new QMK framework * Update files to match new QMK structure * Update files to match new QMK structure * add layout name information * Add info.json * update keymap to support layout_all * update keymap to support layout_all * update rules.mk to fix filesize * Update readme.md * Update config.h * Update readme.md * Update config.h * Update config.h Add "define CONFIG_H and include "config_common.h" back to file
* Add H87a keymap and info * Create readme.md * Add h87a .json for kbfirmware.com use * Update readme.md * Update readme.md * Update h87a files * Delete Makefile * Update readme.md * Delete desktop.ini * update files to match new QMK framework * Update files to match new QMK structure * Update files to match new QMK structure * add layout name information * Add info.json * update keymap to support layout_all * update keymap to support layout_all * update rules.mk to fix filesize * Update readme.md * Update config.h * Update readme.md * Update config.h * Update config.h Add "define CONFIG_H and include "config_common.h" back to file
This PCB has been prototyped and verified working. The prototypes will be sent out to their buyers in the near future.