Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the Zeropad keyboard #24737

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Adding the Zeropad keyboard #24737

wants to merge 13 commits into from

Conversation

diffrentGuesser
Copy link

@diffrentGuesser diffrentGuesser commented Dec 21, 2024 •
edited
Loading

Description

Adding the Zeropad (3x3 costum keyboard) to the keyboards/handwired file and now updating to public

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 21, 2024
@zvecr zvecr added invalid pr_checklist_pending Needs changes as per the PR checklist labels Dec 21, 2024
@zvecr zvecr removed invalid via Adds via keymap and/or updates keyboard for via support pr_checklist_pending Needs changes as per the PR checklist labels Dec 23, 2024
zvecr
zvecr requested changes Dec 23, 2024
View reviewed changes
keyboards/handwired/zeropad/readme.md Outdated
@@ -0,0 +1,27 @@
# handwired/zeropad

![handwired/zeropad](imgur.com image replace me!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs filling out

@diffrentGuesser
Copy link
Author

diffrentGuesser commented Dec 25, 2024 •
edited
Loading

I filled it out. Can it be merged now? Or are there any further changes that need to be made? b5e9331

@zvecr zvecr reopened this Dec 26, 2024
@diffrentGuesser
Copy link
Author

can it be merged. I think I did what i have to and if not please tell me what there is to do.

@zvecr zvecr reopened this Jan 3, 2025
@zvecr
Copy link
Member

zvecr commented Jan 3, 2025

Please stop opening new PRs for this same content. Any more and we will have to consider blocking your account.

While we know that your PR is important to you, it may take some time for QMK collaborators to get to it.

PR reviews are something that is done in their free time -- collaborators are not paid nor compensated for the time spent reviewing, as it is a labor of love. As such, this means that it can take time for them to get to your PR -- things like family, or life can get in the way of finding time to perform reviews, and burnout is a serious consideration. The QMK firmware repository averages 300 PRs opened and 300 PRs merged every month, so please have patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diffrentGuesser @zvecr