Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop 2023q2 changelog #21049

Merged
merged 11 commits into from
May 28, 2023
Prev Previous commit
Apply suggestions from code review
Co-authored-by: Ryan <fauxpark@gmail.com>
  • Loading branch information
tzarc and fauxpark authored May 28, 2023
commit d37fb504a327ca964a152f71adc74f9d3f59c4f1
4 changes: 2 additions & 2 deletions docs/ChangeLog/20230528.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ Of note for keyboard designers:
* Layouts missing from keyboard definitions have been added in the process
* Keys within layouts should not specify `"w":1` or `"h":1` if the key size is 1 -- `w`/`h` should only be present for sizes other than 1
* `config_common.h` has been removed and should not be present anywhere in your keyboard code.
* `RGB_DI_PIN` for will now cause an error during build
* `RGB_DI_PIN` will now cause an error during build:
* For WS2812-like LEDs, this should be moved to `info.json`: `"ws2812": { "pin": "xxx" }`
* For APA102 LEDs, this should be moved to `info.json`: `"apa102": { "data_pin": "xxx" }`
* Other mandatory data-driven changes should be automatically flagged during build
* Keymaps with `encoder_map` should now have the following change made:
* `encoder_map[][NUM_ENCODERS][2]` => `encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS]`
* Users would decide to change the `[2]`, stating "my board only has 1 encoder, so it should be `[1]`", necessitating support
* Users assumed the `2` referred to the number of encoders, rather than the number of directions (which is always 2)

### Repeat last key ([#19700](https://github.com/qmk/qmk_firmware/pull/19700)) :id=repeat-last-key

Expand Down