Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Bad Wings Support #20153
Adding Bad Wings Support #20153
Changes from 9 commits
92ef5e9
fbb8b00
6dba6a6
70fb9d9
fa48da5
b1daca3
07d0529
32b5392
0729977
24cb61e
82f16a8
14bfb74
680876b
66d3b0d
899d7b3
ff96883
6eb9f6a
5b93f3e
29c3033
34bcd82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be at the kb level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're talking just
POINTING_DEVICE_ENABLE
, right? if so, that's been updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per the docs Configurator will choke on
TAP_DANCE_ENABLE
at keyboard level, thoughCAPS_WORD_ENABLE
is fine andTRI_LAYER_ENABLE
probably would be too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I've got a couple other things from the configurator docs that I need to address as well. I'll get started on those, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated my branch with keymap changes required for the configurator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to say this after you already went and did it, but the
default
keymap was fine.Configurator creates an entirely blank keymap, it only has access to the keyboard-level information. It does not use any information from the default keymap.
I can confirm Tri-Layer and Caps Word are both OK to enable at the keyboard level after testing them. The issue is that if you enable Tap Dance without actually implementing any tap dances, compilation fails, and Configurator has no way to implement tap dances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mind updating the default keymap - it was mostly changes I've been wanting to make for a while.<
I've moved
TRI_LAYER_ENABLE
andCAPS_WORD_ENABLE
to the keyboard level rules.mk. Thanks so much for your feedback!