Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Not compatible with milc < 1.9 #192

Closed
liljaylj opened this issue Dec 27, 2024 · 3 comments
Closed

[Bug] Not compatible with milc < 1.9 #192

liljaylj opened this issue Dec 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@liljaylj
Copy link

Describe the Bug

in the official Arch Linux repository there is an outdated version of the python-milc package (1.8.0). this makes the qmk script unusable, because in milc versions before 1.9.0 there was no set_options attribute.

to restore the script's functionality, I suggest adding an attribute check. if it is not there, then fallback to now-deprecated set_metadata.

Additional Context?

No response

@liljaylj liljaylj added the bug Something isn't working label Dec 27, 2024
@tzarc
Copy link
Member

tzarc commented Dec 27, 2024

QMK CLI is marked to require 1.9.0 or later: https://github.com/qmk/qmk_cli/blob/master/setup.cfg#L40

I'm not sure catering for out-of-date downstream packages is the approach we'd like to take.

I'd suggest that the fix would be to get the Arch python-milc package bumped -- we don't control that sadly.

@liljaylj
Copy link
Author

ok. it is understandable.

reported to arch linux repo gitlab (https://gitlab.archlinux.org/archlinux/packaging/packages/python-milc/-/issues/1).

for now, as a workaround, installed qmk in virtual environment until python-milc package will be updated.

@liljaylj
Copy link
Author

closing as not planned

@liljaylj liljaylj closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants