polish alibaba#614

qixiaobo · May 14, 2019 · 487742d · 487742d
1 parent a55034a
commit 487742d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/core/src/main/java/com/taobao/arthas/core/shell/system/impl/ProcessImpl.java b/core/src/main/java/com/taobao/arthas/core/shell/system/impl/ProcessImpl.java
@@ -607,12 +607,10 @@ private void close() {
             if (statisticsHandler != null && flushHandlerChain != null) {
                 String data = statisticsHandler.result();
 
-                if (flushHandlerChain != null) {
-                    for (Function<String, String> function : flushHandlerChain) {
-                        data = function.apply(data);
-                        if (function instanceof StatisticsFunction) {
-                            data = ((StatisticsFunction) function).result();
-                        }
+                for (Function<String, String> function : flushHandlerChain) {
+                    data = function.apply(data);
+                    if (function instanceof StatisticsFunction) {
+                        data = ((StatisticsFunction) function).result();
                     }
                 }
             }

diff --git a/memorycompiler/src/main/java/com/taobao/arthas/compiler/DynamicCompilerException.java b/memorycompiler/src/main/java/com/taobao/arthas/compiler/DynamicCompilerException.java
@@ -54,13 +54,11 @@ private List<Map<String, Object>> getErrorList() {
     private String getErrors() {
         StringBuilder errors = new StringBuilder();
 
-        for (Map<String, Object> entry : getErrorList()) {
-
-            for (String key : entry.keySet()) {
-
-                Object value = entry.get(key);
+        for (Map<String, Object> message : getErrorList()) {
+            for (Map.Entry<String, Object> entry : message.entrySet()) {
+                Object value = entry.getValue();
                 if (value != null && !value.toString().isEmpty()) {
-                    errors.append(key);
+                    errors.append(entry.getKey());
                     errors.append(": ");
                     errors.append(value);
                 }