Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: custom config for coding and jam-codec compatibility #29

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Feature: custom config for coding and jam-codec compatibility #29

merged 11 commits into from
Dec 9, 2024

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Dec 3, 2024

Added and implemented following options

option(JAM_COMPATIBLE "Build compatible with JAM-codec" OFF)
option(CUSTOM_CONFIG_SUPPORT "Support custom config of streams" OFF)

@xDimon
feature: custom confing for en-/decoding and jam-codec compatibility
097383c 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon requested review from Harrm and turuslan December 3, 2024 12:44
@xDimon
fix: mac CI
46f1c35 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
turuslan
turuslan reviewed Dec 3, 2024
View reviewed changes
include/scale/scale_decoder_stream.hpp Outdated Show resolved Hide resolved
include/scale/scale_decoder_stream.hpp Outdated Show resolved Hide resolved
include/scale/scale_decoder_stream.hpp Show resolved Hide resolved
include/scale/scale_decoder_stream.hpp Outdated Show resolved Hide resolved
include/scale/scale_encoder_stream.hpp Outdated Show resolved Hide resolved
include/scale/detail/jam_compact_integer.hpp Show resolved Hide resolved
xDimon added 3 commits December 9, 2024 11:54
@xDimon
fix: review issues
0fcd42f 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
fix: review issue
34da865 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
fix: review issue
a478d4d 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon requested a review from turuslan December 9, 2024 07:56
xDimon added 3 commits December 9, 2024 16:08
@xDimon
fix: broken build
8202755 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
fix: typo
1d6a6ec 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
fix: typo
03360e1 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
turuslan
turuslan previously approved these changes Dec 9, 2024
View reviewed changes
include/scale/configurable.hpp Outdated Show resolved Hide resolved
@xDimon
fix: review issue
11e08f1 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon requested review from turuslan and kamilsa and removed request for Harrm December 9, 2024 08:40
turuslan
turuslan previously approved these changes Dec 9, 2024
View reviewed changes
kamilsa
kamilsa previously approved these changes Dec 9, 2024
View reviewed changes
include/scale/scale_decoder_stream.hpp Outdated Show resolved Hide resolved
include/scale/scale_encoder_stream.hpp Outdated Show resolved Hide resolved
src/compact_len_utils.hpp Outdated Show resolved Hide resolved
@xDimon
fix: review issue
2d47f19 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon dismissed stale reviews from kamilsa and turuslan via 2d47f19 December 9, 2024 12:00
@xDimon xDimon enabled auto-merge (squash) December 9, 2024 12:07
@xDimon xDimon merged commit 7a5e8a7 into master Dec 9, 2024
4 checks passed
@xDimon xDimon deleted the feature/jam_compatibility branch December 9, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turuslan turuslan turuslan approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xDimon @kamilsa @turuslan