Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix different wal crate versions #4064

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix different wal crate versions #4064

merged 1 commit into from
Apr 18, 2024

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented Apr 18, 2024 •
edited
Loading

The collection crate and the storage crate use different version of the wal crate.

The gap is represented by those two PRs:

In order to avoid subtle compatibility issues, I have unified the version in the workspace and bumped to the latest revision.

@agourlay agourlay requested a review from timvisee April 18, 2024 09:28
timvisee
timvisee approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all will be green.

@agourlay agourlay merged commit d67bee1 into dev Apr 18, 2024
17 checks passed
@agourlay agourlay deleted the fix-wal-versions branch April 18, 2024 09:41
timvisee pushed a commit that referenced this pull request Apr 22, 2024
@agourlay @timvisee
Fix different wal crate versions (#4064)
e1c21b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agourlay @timvisee