Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes method from abort shard transfer operation #3681

Closed
wants to merge 0 commits into from
Closed

Removes method from abort shard transfer operation #3681

wants to merge 0 commits into from

Conversation

RPallas92
Copy link
Contributor

Tracked in: #3409

This PR adds a new AbortShardTransfer struct, to be used by the AbortTransfer operation.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change? - There is one, but the CI does not pass.

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@timvisee
Copy link
Member

Hi @RPallas92, thank you for your effort on this!

Could you first make sure the tests on CI pass? This probably needs a reformat: cargo +nightly fmt --all

@RPallas92
Copy link
Contributor Author

cc: @timvisee

Hi @RPallas92, thank you for your effort on this!

Could you first make sure the tests on CI pass? This probably needs a reformat: cargo +nightly fmt --all

Hi @timvisee, thanks for reviewing. Sure, I have updated the PR, but I don´t have permissions to re-run the checks.

@RPallas92
Copy link
Contributor Author

cc: @timvisee

Hi @RPallas92, thank you for your effort on this!
Could you first make sure the tests on CI pass? This probably needs a reformat: cargo +nightly fmt --all

Hi @timvisee, thanks for reviewing. Sure, I have updated the PR, but I don´t have permissions to re-run the checks.

Should I reopen the PR to force running the checks?

@xzfc
Copy link
Contributor

xzfc commented Feb 26, 2024

I reran the checks. It seems you also need to regenerate JSON/gRPC schemas by running tools/generate_grpc_docs.sh and tools/generate_openapi_models.sh.

@RPallas92 RPallas92 closed this Mar 9, 2024
@RPallas92
Copy link
Contributor Author

Closed in favor of #3803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RPallas92 @timvisee @xzfc