Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shard snapshot gRPC API #2825

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Add shard snapshot gRPC API #2825

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ab96493
Fix paste-bugs in `snapshot_service.proto`
ffuugoo Oct 16, 2023
ca6f8cf
Add shard snapshot gRCP API definition
ffuugoo Oct 16, 2023
5e85962
Add validation to shard snapshot gRPC API definition
ffuugoo Oct 16, 2023
c661165
Implement conversions between gRPC and `collection` types
ffuugoo Oct 16, 2023
cdf787f
Extract shard snapshot API implementation into common sub-module
ffuugoo Oct 16, 2023
c41ffd2
Implement shard snapshot gRPC API
ffuugoo Oct 16, 2023
6f25046
Generate gRPC docs
ffuugoo Oct 16, 2023
c7139a2
Refactor `ShardSnapshots` gRPC service to be internal API only
ffuugoo Oct 17, 2023
96f4876
fixup! Refactor `ShardSnapshots` gRPC service to be internal API only
ffuugoo Oct 17, 2023
42f6643
fixup! fixup! Refactor `ShardSnapshots` gRPC service to be internal A…
ffuugoo Oct 17, 2023
7c0ca94
fixup! fixup! Refactor `ShardSnapshots` gRPC service to be internal A…
ffuugoo Oct 17, 2023
fc4ce2e
Switch `ShardSnapshots` gRPC service to use `validate_and_log` instea…
ffuugoo Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Switch ShardSnapshots gRPC service to use validate_and_log instea… 
…d of `validate`
  • Loading branch information
@ffuugoo
ffuugoo committed Oct 17, 2023
commit fc4ce2e5b6f41f365cfebf96388bf1f311fc4404
10 changes: 5 additions & 5 deletions src/tonic/api/snapshots_api.rs
View file
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ use storage::content_manager::toc::TableOfContent;
use storage::dispatcher::Dispatcher;
use tonic::{async_trait, Request, Response, Status};

use super::validate;
use super::{validate, validate_and_log};
use crate::common;
use crate::common::collections::{do_create_snapshot, do_list_snapshots};

@@ -152,7 +152,7 @@ impl ShardSnapshots for ShardSnapshotsService {
request: Request<CreateShardSnapshotRequest>,
) -> Result<Response<CreateSnapshotResponse>, Status> {
let request = request.into_inner();
validate(&request)?;
validate_and_log(&request);

let timing = Instant::now();

@@ -175,7 +175,7 @@ impl ShardSnapshots for ShardSnapshotsService {
request: Request<ListShardSnapshotsRequest>,
) -> Result<Response<ListSnapshotsResponse>, Status> {
let request = request.into_inner();
validate(&request)?;
validate_and_log(&request);

let timing = Instant::now();

@@ -198,7 +198,7 @@ impl ShardSnapshots for ShardSnapshotsService {
request: Request<DeleteShardSnapshotRequest>,
) -> Result<Response<DeleteSnapshotResponse>, Status> {
let request = request.into_inner();
validate(&request)?;
validate_and_log(&request);

let timing = Instant::now();

@@ -221,7 +221,7 @@ impl ShardSnapshots for ShardSnapshotsService {
request: Request<RecoverShardSnapshotRequest>,
) -> Result<Response<RecoverSnapshotResponse>, Status> {
let request = request.into_inner();
validate(&request)?;
validate_and_log(&request);

let timing = Instant::now();