Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isNull condition for payload filtering #1617

Merged
merged 17 commits into from
Apr 1, 2023
Merged

add isNull condition for payload filtering #1617

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
82d9f56
add minimal working is_null filter
ibrahim-akrab Mar 28, 2023
75decc4
add is_null condition to grpc api (backward compatible)
ibrahim-akrab Mar 28, 2023
d988d55
add unit tests is_null and is_empty conditions
ibrahim-akrab Mar 28, 2023
aafb6ef
add is_null to points.proto file
ibrahim-akrab Mar 28, 2023
de40037
add some failing OpenAPI tests
ibrahim-akrab Mar 29, 2023
c09a621
fix a failing test due to change in collection data
ibrahim-akrab Mar 29, 2023
47837c5
refactor MultiValue's check for is_null
ibrahim-akrab Mar 29, 2023
ce3feb8
fix is_empty condition not picking up "key":[]
ibrahim-akrab Mar 29, 2023
7ecbd64
remove duplicate OpenAPI integration test
ibrahim-akrab Mar 29, 2023
6c4baae
reuse same variable in condition checker tests
ibrahim-akrab Mar 29, 2023
ed0f3e9
update grpc docs
ibrahim-akrab Mar 30, 2023
19977b4
fix is_null cardinality estimation to match is_empty
ibrahim-akrab Mar 30, 2023
48b303e
update openapi specs
ibrahim-akrab Mar 30, 2023
2a6a828
remove unused debug statements
ibrahim-akrab Mar 30, 2023
4eef537
add new test points to original test_collection
ibrahim-akrab Mar 30, 2023
974ceb2
fix failing tests according to newly added points
ibrahim-akrab Mar 30, 2023
3bcac3b
add the `"key":[null]` test_case
ibrahim-akrab Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reuse same variable in condition checker tests
  • Loading branch information
@ibrahim-akrab
ibrahim-akrab committed Mar 29, 2023
commit 6c4baae2624d067d4522dc110790c18bd36511d8
33 changes: 15 additions & 18 deletions lib/segment/src/payload_storage/query_checker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,56 +260,54 @@ mod tests {
Arc::new(AtomicRefCell::new(id_tracker)),
);

let is_empty_condition_1 = Filter::new_must(Condition::IsEmpty(IsEmptyCondition {
let is_empty_condition = Filter::new_must(Condition::IsEmpty(IsEmptyCondition {
is_empty: PayloadField {
key: "price".to_string(),
},
}));
assert!(!payload_checker.check(0, &is_empty_condition));

let is_empty_condition_2 = Filter::new_must(Condition::IsEmpty(IsEmptyCondition {
let is_empty_condition = Filter::new_must(Condition::IsEmpty(IsEmptyCondition {
is_empty: PayloadField {
key: "something_new".to_string(),
},
}));
assert!(payload_checker.check(0, &is_empty_condition));

let is_empty_condition_3 = Filter::new_must(Condition::IsEmpty(IsEmptyCondition {
let is_empty_condition = Filter::new_must(Condition::IsEmpty(IsEmptyCondition {
is_empty: PayloadField {
key: "parts".to_string(),
},
}));
assert!(payload_checker.check(0, &is_empty_condition));

assert!(!payload_checker.check(0, &is_empty_condition_1));
assert!(payload_checker.check(0, &is_empty_condition_2));
assert!(payload_checker.check(0, &is_empty_condition_3));

let is_null_condition_1 = Filter::new_must(Condition::IsNull(IsNullCondition {
let is_null_condition = Filter::new_must(Condition::IsNull(IsNullCondition {
is_null: PayloadField {
key: "amount".to_string(),
},
}));
assert!(!payload_checker.check(0, &is_null_condition));

let is_null_condition_2 = Filter::new_must(Condition::IsNull(IsNullCondition {
let is_null_condition = Filter::new_must(Condition::IsNull(IsNullCondition {
is_null: PayloadField {
key: "parts".to_string(),
},
}));
assert!(!payload_checker.check(0, &is_null_condition));

let is_null_condition_3 = Filter::new_must(Condition::IsNull(IsNullCondition {
let is_null_condition = Filter::new_must(Condition::IsNull(IsNullCondition {
is_null: PayloadField {
key: "something_else".to_string(),
},
}));
assert!(!payload_checker.check(0, &is_null_condition));

let is_null_condition_4 = Filter::new_must(Condition::IsNull(IsNullCondition {
let is_null_condition = Filter::new_must(Condition::IsNull(IsNullCondition {
is_null: PayloadField {
key: "packaging".to_string(),
},
}));

assert!(!payload_checker.check(0, &is_null_condition_1));
assert!(!payload_checker.check(0, &is_null_condition_2));
assert!(!payload_checker.check(0, &is_null_condition_3));
assert!(payload_checker.check(0, &is_null_condition_4));
assert!(payload_checker.check(0, &is_null_condition));

let match_red = Condition::Field(FieldCondition::new_match(
"color".to_string(),
Expand All @@ -334,6 +332,7 @@ mod tests {
lte: None,
},
)));
assert!(!payload_checker.check(0, &many_value_count_condition));

let few_value_count_condition =
Filter::new_must(Condition::Field(FieldCondition::new_values_count(
Expand All @@ -345,8 +344,6 @@ mod tests {
lte: None,
},
)));

assert!(!payload_checker.check(0, &many_value_count_condition));
assert!(payload_checker.check(0, &few_value_count_condition));

let in_berlin = Condition::Field(FieldCondition::new_geo_bounding_box(
Expand Down