provide flag

qdrant · generall · Mar 3, 2023 · Jan 3, 2023 · Jan 3, 2023 · Jan 3, 2023
commit 6749bebc1d1aff12d0a150673e46c5ef316108f7
diff --git a/lib/collection/src/collection_manager/optimizers/segment_optimizer.rs b/lib/collection/src/collection_manager/optimizers/segment_optimizer.rs
@@ -248,7 +248,7 @@ pub trait SegmentOptimizer {
             match segment {
                 LockedSegment::Original(segment_arc) => {
                     let segment_guard = segment_arc.read();
-                    segment_builder.update_from(&segment_guard, stopped)?;
+                    segment_builder.update_from(&segment_guard, stopped, false)?;
                 }
                 LockedSegment::Proxy(_) => panic!("Attempt to optimize segment which is already currently under optimization. Should never happen"),
             }

diff --git a/lib/segment/src/segment_constructor/segment_builder.rs b/lib/segment/src/segment_constructor/segment_builder.rs
@@ -51,7 +51,7 @@ impl SegmentBuilder {
     ///
     /// * `bool` - if `true` - data successfully added, if `false` - process was interrupted
     ///
-    pub fn update_from(&mut self, other: &Segment, stopped: &AtomicBool) -> OperationResult<bool> {
+    pub fn update_from(&mut self, other: &Segment, stopped: &AtomicBool, quantize: bool) -> OperationResult<bool> {
         match &mut self.segment {
             None => Err(OperationError::service_error(
                 "Segment building error: created segment not found",
@@ -103,7 +103,9 @@ impl SegmentBuilder {
                         vector_storage.update_from(&**other_vector_storage, stopped)?;
                     internal_id_iter =
                         Some(new_internal_range.zip(other_vector_storage.iter_ids()));
-                    vector_storage.quantize()?;
+                    if quantize {
+                        vector_storage.quantize()?;
+                    }
                 }
                 if internal_id_iter.is_none() {
                     return Err(OperationError::service_error(

diff --git a/lib/segment/tests/segment_builder_test.rs b/lib/segment/tests/segment_builder_test.rs
@@ -38,9 +38,9 @@ mod tests {
             .upsert_vector(100, 3.into(), &only_default_vector(&[0., 0., 0., 0.]))
             .unwrap();
 
-        builder.update_from(&segment1, &stopped).unwrap();
-        builder.update_from(&segment2, &stopped).unwrap();
-        builder.update_from(&segment2, &stopped).unwrap();
+        builder.update_from(&segment1, &stopped, false).unwrap();
+        builder.update_from(&segment2, &stopped, false).unwrap();
+        builder.update_from(&segment2, &stopped, false).unwrap();
 
         // Check what happens if segment building fails here
 
@@ -94,7 +94,7 @@ mod tests {
         let mut builder =
             SegmentBuilder::new(dir.path(), temp_dir.path(), &segment_config).unwrap();
 
-        builder.update_from(segment, &stopped).unwrap();
+        builder.update_from(segment, &stopped, false).unwrap();
 
         let now = Instant::now();