Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Replace with_vector with with_vectors #60

Closed
wants to merge 1 commit into from

Conversation

kacperlukawski
Copy link
Member

This PR uses the plural form for all the occurrences of the with_vector parameter. It makes the docs consistent with the current naming.

@kacperlukawski kacperlukawski requested a review from generall March 13, 2023 11:11
@@ -499,7 +499,7 @@ POST /collections/{collection_name}/points/scroll
},
"limit": 1,
"with_payload": true,
"with_vector": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is with_vector in REST API, we will make alias first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@coszio coszio May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented in qdrant/qdrant#1697 👍, though it now belongs to the 1.1.x (and forward) docs

@davidmyriel
Copy link
Contributor

added to new repo

@davidmyriel davidmyriel closed this Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants