Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test of backbone utils #5552

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Mar 4, 2022

Improve test of backbone utils.

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 4, 2022

💊 CI failures summary and remediations

As of commit 4d9d109 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox changed the title [Feature] Improve test of backbone utils Improve test of backbone utils Mar 4, 2022
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @talregev. A few minor comments below but the rest looks good.

test/test_backbone_utils.py Outdated Show resolved Hide resolved
test/test_backbone_utils.py Outdated Show resolved Hide resolved
test/test_backbone_utils.py Outdated Show resolved Hide resolved
@talregev talregev force-pushed the TalR/improve_backbond_utils_tests branch 8 times, most recently from fd3cebc to 79ba631 Compare March 10, 2022 16:13
@talregev talregev force-pushed the TalR/improve_backbond_utils_tests branch from 79ba631 to 4d9d109 Compare March 11, 2022 05:24
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datumbox datumbox merged commit 090d823 into pytorch:main Mar 11, 2022
@talregev talregev deleted the TalR/improve_backbond_utils_tests branch March 12, 2022 09:58
facebook-github-bot pushed a commit that referenced this pull request Mar 15, 2022
Reviewed By: vmoens

Differential Revision: D34878974

fbshipit-source-id: fd30940d4681e4f6c99f0ee6414ef5b2dbb012cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants