-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test of backbone utils #5552
Improve test of backbone utils #5552
Conversation
💊 CI failures summary and remediationsAs of commit 4d9d109 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @talregev. A few minor comments below but the rest looks good.
fd3cebc
to
79ba631
Compare
79ba631
to
4d9d109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviewed By: vmoens Differential Revision: D34878974 fbshipit-source-id: fd30940d4681e4f6c99f0ee6414ef5b2dbb012cc
Improve test of backbone utils.