add LSUN prototype dataset #5390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 66ba84a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
commented
Feb 8, 2022
Comment on lines
+72
to
+75
| def _loader(self, path: pathlib.Path) -> IterDataPipe[str]: | ||
| # LMDB datasets cannot be loaded through an open file handle, but have to be loaded through the path of the | ||
| # parent directory. | ||
| return IterableWrapper([str(next(path.rglob("data.mdb")).parent)]) |
There was a problem hiding this comment.
@NicolasHug this would have been supported with the loader parameter we removed in #5282. But I guess since this is (currently) the only case that needs this, we can special case it.
pmeier
commented
Feb 8, 2022
pmeier
commented
Feb 8, 2022
This was referenced Apr 7, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5345.