Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying output channels in io.image.read_image #2988

Merged
merged 16 commits into from
Nov 18, 2020
Merged

Support specifying output channels in io.image.read_image #2988

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d3ea66f
Adding output channels implementation for pngs.
datumbox Nov 11, 2020
d5871a7
Adding tests for png.
datumbox Nov 11, 2020
cac58ac
Adding channels in the API and documentation.
datumbox Nov 11, 2020
c579341
Fixing formatting.
datumbox Nov 11, 2020
115338c
Refactoring test_image.py to remove huge grace_hopper_517x606.pth fil…
datumbox Nov 11, 2020
b3d69fa
Adding output channels implementation for jpegs. Fix asset locations.
datumbox Nov 11, 2020
f44f26e
Add tests for JPEG, adding the channels in the API and documentation …
datumbox Nov 11, 2020
7ea166d
Changing folder for unit-test.
datumbox Nov 11, 2020
e643a75
Fixing windows flakiness, removing duplicate test.
datumbox Nov 11, 2020
ed59745
Merge branch 'master' into feature/channels_in_read_image
datumbox Nov 12, 2020
f221cf3
Replacing components to channels.
datumbox Nov 13, 2020
110009a
Adding reference for supporting CMYK.
datumbox Nov 13, 2020
c72f861
Minor changes: num_components to output_components, adding comments, …
datumbox Nov 13, 2020
161dbce
Reverting output_components to num_components.
datumbox Nov 13, 2020
c81548c
Replacing decoding with generic method on tests.
datumbox Nov 16, 2020
ada56a2
Palette converted to Gray.
datumbox Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replacing decoding with generic method on tests.
  • Loading branch information
@datumbox
datumbox committed Nov 16, 2020
commit c81548c8831c27978e36f71dd8cc1d3af371566b
4 changes: 2 additions & 2 deletions test/test_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_decode_jpeg(self):

img_pil = normalize_dimensions(img_pil)
data = read_file(img_path)
img_ljpeg = decode_jpeg(data, channels=channels)
img_ljpeg = decode_image(data, channels=channels)

# Permit a small variation on pixel values to account for implementation
# differences between Pillow and LibJPEG.
Expand Down Expand Up @@ -176,7 +176,7 @@ def test_decode_png(self):

img_pil = normalize_dimensions(img_pil)
data = read_file(img_path)
img_lpng = decode_png(data, channels=channels)
img_lpng = decode_image(data, channels=channels)

tol = 0 if conversion is None else 1
self.assertTrue(img_lpng.allclose(img_pil, atol=tol))
fmassa marked this conversation as resolved.
Show resolved Hide resolved
Expand Down