Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Regex, RegexTokenizer, Vocab, Vectors, SentencePiece pickle-able #1104

Merged
merged 7 commits into from
Dec 22, 2020
Merged

Make Regex, RegexTokenizer, Vocab, Vectors, SentencePiece pickle-able #1104

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23b476e
Make Regex, RegexTokenizer, Vocab, Vectors, SentencePiece pickle-able
mthrok Dec 16, 2020
4dab9cb
Use byte tensor for SPM serialization
mthrok Dec 17, 2020
20b19bc
Fix narrowing
mthrok Dec 17, 2020
fc65387
Clean up test
mthrok Dec 17, 2020
613ee82
Copy memory when serializing SentencePiece
mthrok Dec 17, 2020
5b8f220
Fix rtype reference
mthrok Dec 18, 2020
d6249f8
Merge branch 'master' into sp-binding2
zhangguanheng66 Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Copy memory when serializing SentencePiece
  • Loading branch information
@mthrok
mthrok committed Dec 21, 2020
commit 613ee820dd62ffc5b5c4e2dbc61306dcd2062053
2 changes: 1 addition & 1 deletion torchtext/csrc/register_bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ TORCH_LIBRARY_FRAGMENT(torchtext, m) {
[](const c10::intrusive_ptr<SentencePiece> &self) -> torch::Tensor {
auto *data = static_cast<void*>(const_cast<char*>(self->content_.data()));
auto numel = static_cast<int64_t>(self->content_.size());
return torch::from_blob(data, {numel}, {torch::kUInt8});
return torch::from_blob(data, {numel}, {torch::kUInt8}).clone();
},
// __setstate__
[](torch::Tensor state) -> c10::intrusive_ptr<SentencePiece> {
Expand Down