amend

pytorch · vmoens · Nov 14, 2023 · Jul 21, 2023 · Jul 21, 2023 · Aug 11, 2023
commit 4fc0bcb2a067c604c6c1e846dc8017d0c35aaebb
diff --git a/tensordict/memmap_refact.py b/tensordict/memmap_refact.py
@@ -105,7 +105,7 @@ def from_tensor(
             handler = None
             out = cls(
                 torch.from_file(
-                    filename, shared=True, dtype=tensor.dtype, size=shape.numel()
+                    str(filename), shared=True, dtype=tensor.dtype, size=shape.numel()
                 ).view(tensor.shape)
             )
         out.handler = handler

diff --git a/test/test_memmap2.py b/test/test_memmap2.py
@@ -70,15 +70,6 @@ def test_memmap_data_type(dtype, shape):
     assert m.clone().shape == t.shape
 
 
-def test_memmap_del(tmpdir):
-    filename = tmpdir / "tensor"
-    t = torch.tensor([1])
-    m = MemmapTensor.from_tensor(t, filename=filename)
-    # filename = m.filename
-    assert os.path.isfile(filename)
-    del m
-    assert not os.path.isfile(filename)
-
 
 # @pytest.mark.parametrize("transfer_ownership", [True, False])
 # def test_memmap_ownership(transfer_ownership):
@@ -550,6 +541,13 @@ def test_ne(self, device):
         )
         assert (memmap != ~memmap).all()
 
+def test_memmap_del(tmpdir):
+    t = torch.tensor([1])
+    m = MemmapTensor.from_tensor(t, filename=tmpdir / "tensor")
+    # filename = m.filename
+    assert os.path.isfile(tmpdir / "tensor")
+    del m
+    assert not os.path.isfile(tmpdir / "tensor")
 
 if __name__ == "__main__":
     args, unknown = argparse.ArgumentParser().parse_known_args()