Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix CompositeSpec.to_numpy method #931

Merged
merged 7 commits into from
Feb 21, 2023
Merged

[BugFix] Fix CompositeSpec.to_numpy method #931

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97ddd1a
Replace _to_numpy by to_numpy
riiswa Feb 21, 2023
2d0cfb1
Add unit test
riiswa Feb 21, 2023
f02d7e0
init
vmoens Feb 21, 2023
c2b7659
amend
vmoens Feb 21, 2023
287de7f
amend
vmoens Feb 21, 2023
358807d
amend
vmoens Feb 21, 2023
7469d01
Merge branch 'fix_envpool' into fix/composite_spec_to_numpy
vmoens Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Replace _to_numpy by to_numpy
  • Loading branch information
@riiswa
riiswa committed Feb 21, 2023
commit 97ddd1ad16bedf790bff6637deaab9eea8a49414
2 changes: 1 addition & 1 deletion torchrl/data/tensor_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,7 +1947,7 @@ def clone(self) -> CompositeSpec:
)

def to_numpy(self, val: TensorDict, safe: bool = True) -> dict:
return {key: self[key]._to_numpy(val) for key, val in val.items()}
return {key: self[key].to_numpy(val) for key, val in val.items()}

def zero(self, shape=None) -> TensorDictBase:
if shape is None:
Expand Down