Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Dict specs in vmas #2415

Merged
merged 3 commits into from
Sep 4, 2024
Merged

[Feature] Dict specs in vmas #2415

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b807bb7
amend
matteobettini Sep 3, 2024
ac5e5ef
amend
matteobettini Sep 4, 2024
ed585a8
empty
vmoens Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
amend
  • Loading branch information
@matteobettini
matteobettini committed Sep 3, 2024
commit b807bb7b76359ca3f220cde18e48d0abf83207ab
11 changes: 11 additions & 0 deletions torchrl/envs/libs/vmas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@ def _vmas_to_torchrl_spec_transform(
device=device,
)
)
elif isinstance(spec, gym_spaces.Dict):
spec_out = {}
for k in spec.keys():
key = k
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. I have no idea why that was in my code. I hope it was not there for some dark magic that i forgot about

spec_out[key] = _vmas_to_torchrl_spec_transform(
spec[k],
device=device,
categorical_action_encoding=categorical_action_encoding,
)
# the batch-size must be set later
return Composite(spec_out, device=device)
else:
raise NotImplementedError(
f"spec of type {type(spec).__name__} is currently unaccounted for vmas"
Expand Down
Loading