Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Use a RL-specific NO_DEFAULT instead of TD's one #2367

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[BugFix] Use a RL-specific NO_DEFAULT instead of TD's one #2367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions torchrl/data/tensor_specs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from __future__ import annotations

import abc
import enum
import math
import warnings
from collections.abc import Iterable
Expand Down Expand Up @@ -81,6 +82,15 @@
)


# Akin to TD's NO_DEFAULT but won't raise a KeyError when found in a TD or used as default
class _NoDefault(enum.IntEnum):
ZERO = 0
ONE = 1


NO_DEFAULT_RL = _NoDefault.ONE


def _default_dtype_and_device(
dtype: Union[None, torch.dtype],
device: Union[None, str, int, torch.device],
Expand Down
2 changes: 1 addition & 1 deletion torchrl/envs/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

from torchrl.data.tensor_specs import (
CompositeSpec,
NO_DEFAULT,
NO_DEFAULT_RL as NO_DEFAULT,
TensorSpec,
UnboundedContinuousTensorSpec,
)
Expand Down
Loading