Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix, CI] Set TD_GET_DEFAULTS_TO_NONE=1 in all CIs #2363

Merged
merged 5 commits into from
Aug 5, 2024
Merged

[BugFix, CI] Set TD_GET_DEFAULTS_TO_NONE=1 in all CIs #2363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4af379a
init
vmoens Aug 5, 2024
7a6ee15
amend
vmoens Aug 5, 2024
4587773
amend
vmoens Aug 5, 2024
12c2717
empty
vmoens Aug 5, 2024
6038c7d
amend
vmoens Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
@vmoens
vmoens committed Aug 5, 2024
commit 7a6ee15883ae7050cd0b84d7f10f5cbb4e96779c
10 changes: 6 additions & 4 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,13 @@ jobs:
python-version: 3.8
- name: Setup Environment
run: |
python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
python -m pip install git+https://github.com/pytorch/tensordict
python setup.py develop
python -m pip install pytest pytest-benchmark
python3 -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
python3 -m pip install git+https://github.com/pytorch/tensordict
python3 setup.py develop
python3 -m pip install pytest pytest-benchmark
python3 -m pip install "gym[accept-rom-license,atari]"
python3 -m pip install dm_control
export TD_GET_DEFAULTS_TO_NONE=1
- name: Run benchmarks
run: |
cd benchmarks/
Expand Down Expand Up @@ -97,6 +98,7 @@ jobs:
python3 -m pip install pytest pytest-benchmark
python3 -m pip install "gym[accept-rom-license,atari]"
python3 -m pip install dm_control
export TD_GET_DEFAULTS_TO_NONE=1
- name: check GPU presence
run: |
python -c """import torch
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/benchmarks_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ jobs:
python-version: 3.8
- name: Setup Environment
run: |
python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
python -m pip install git+https://github.com/pytorch/tensordict
python setup.py develop
python -m pip install pytest pytest-benchmark
python3 -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
python3 -m pip install git+https://github.com/pytorch/tensordict
python3 setup.py develop
python3 -m pip install pytest pytest-benchmark
python3 -m pip install "gym[accept-rom-license,atari]"
python3 -m pip install dm_control
export TD_GET_DEFAULTS_TO_NONE=1
- name: Setup benchmarks
run: |
echo "BASE_SHA=$(echo ${{ github.event.pull_request.base.sha }} | cut -c1-8)" >> $GITHUB_ENV
Expand Down Expand Up @@ -108,6 +109,7 @@ jobs:
python3 -m pip install pytest pytest-benchmark
python3 -m pip install "gym[accept-rom-license,atari]"
python3 -m pip install dm_control
export TD_GET_DEFAULTS_TO_NONE=1
- name: check GPU presence
run: |
python -c """import torch
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-linux-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:

echo "PYTHON_VERSION: $PYTHON_VERSION"
echo "CU_VERSION: $CU_VERSION"
export TD_GET_DEFAULTS_TO_NONE=1

## setup_env.sh
bash .github/unittest/linux_examples/scripts/run_all.sh
1 change: 1 addition & 0 deletions .github/workflows/test-linux-habitat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,6 @@ jobs:
export CU_VERSION="cu${CUDA_ARCH_VERSION:0:2}${CUDA_ARCH_VERSION:3:1}"
# Remove the following line when the GPU tests are working inside docker, and uncomment the above lines
#export CU_VERSION="cpu"
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_habitat/run_all.sh
17 changes: 17 additions & 0 deletions .github/workflows/test-linux-libs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
export TAR_OPTIONS="--no-same-owner"
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_ataridqn/setup_env.sh
bash .github/unittest/linux_libs/scripts_ataridqn/install.sh
Expand Down Expand Up @@ -81,6 +82,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

nvidia-smi

Expand Down Expand Up @@ -114,6 +116,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_d4rl/setup_env.sh
bash .github/unittest/linux_libs/scripts_d4rl/install.sh
Expand Down Expand Up @@ -148,6 +151,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_d4rl/setup_env.sh
bash .github/unittest/linux_libs/scripts_d4rl/install.sh
Expand Down Expand Up @@ -181,6 +185,7 @@ jobs:
export TAR_OPTIONS="--no-same-owner"
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_gen-dgrl/setup_env.sh
bash .github/unittest/linux_libs/scripts_gen-dgrl/install.sh
Expand Down Expand Up @@ -216,6 +221,7 @@ jobs:
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/work/mujoco-py/mujoco_py/binaries/linux/mujoco210/bin"
export TAR_OPTIONS="--no-same-owner"
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

./.github/unittest/linux_libs/scripts_gym/setup_env.sh
./.github/unittest/linux_libs/scripts_gym/batch_scripts.sh
Expand Down Expand Up @@ -251,6 +257,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

nvidia-smi

Expand Down Expand Up @@ -285,6 +292,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

nvidia-smi

Expand Down Expand Up @@ -321,6 +329,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_minari/setup_env.sh
bash .github/unittest/linux_libs/scripts_minari/install.sh
Expand Down Expand Up @@ -355,6 +364,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_openx/setup_env.sh
bash .github/unittest/linux_libs/scripts_openx/install.sh
Expand Down Expand Up @@ -387,6 +397,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

nvidia-smi

Expand Down Expand Up @@ -423,6 +434,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_robohive/setup_env.sh
bash .github/unittest/linux_libs/scripts_robohive/install_and_run_test.sh
Expand Down Expand Up @@ -456,6 +468,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_roboset/setup_env.sh
bash .github/unittest/linux_libs/scripts_roboset/install.sh
Expand Down Expand Up @@ -491,6 +504,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_sklearn/setup_env.sh
bash .github/unittest/linux_libs/scripts_sklearn/install.sh
Expand Down Expand Up @@ -527,6 +541,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

nvidia-smi

Expand Down Expand Up @@ -563,6 +578,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_vd4rl/setup_env.sh
bash .github/unittest/linux_libs/scripts_vd4rl/install.sh
Expand Down Expand Up @@ -599,6 +615,7 @@ jobs:
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export BATCHED_PIPE_TIMEOUT=60
export TD_GET_DEFAULTS_TO_NONE=1

nvidia-smi

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-linux-rlhf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
export TAR_OPTIONS="--no-same-owner"
export UPLOAD_CHANNEL="nightly"
export TF_CPP_MIN_LOG_LEVEL=0
export TD_GET_DEFAULTS_TO_NONE=1

bash .github/unittest/linux_libs/scripts_rlhf/setup_env.sh
bash .github/unittest/linux_libs/scripts_rlhf/install.sh
Expand Down
38 changes: 38 additions & 0 deletions .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,39 @@ jobs:
export RELEASE=0
export TORCH_VERSION=nightly
fi
export TD_GET_DEFAULTS_TO_NONE=1
# Set env vars from matrix
export PYTHON_VERSION=${{ matrix.python_version }}
export CU_VERSION="cpu"

echo "PYTHON_VERSION: $PYTHON_VERSION"
echo "CU_VERSION: $CU_VERSION"

## setup_env.sh
bash .github/unittest/linux/scripts/run_all.sh

tests-cpu-oldget:
# Tests that TD_GET_DEFAULTS_TO_NONE=0 works fine as this will be the default for TD up to 0.7
strategy:
matrix:
python_version: ["3.12"]
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
with:
runner: linux.12xlarge
repository: pytorch/rl
docker-image: "nvidia/cuda:12.2.0-devel-ubuntu22.04"
timeout: 90
script: |
if [[ "${{ github.ref }}" =~ release/* ]]; then
export RELEASE=1
export TORCH_VERSION=stable
else
export RELEASE=0
export TORCH_VERSION=nightly
fi
export TD_GET_DEFAULTS_TO_NONE=0

# Set env vars from matrix
export PYTHON_VERSION=${{ matrix.python_version }}
export CU_VERSION="cpu"
Expand Down Expand Up @@ -75,6 +108,8 @@ jobs:
export RELEASE=0
export TORCH_VERSION=nightly
fi
export TD_GET_DEFAULTS_TO_NONE=1

# Remove the following line when the GPU tests are working inside docker, and uncomment the above lines
#export CU_VERSION="cpu"

Expand Down Expand Up @@ -110,6 +145,7 @@ jobs:
export TORCH_VERSION=nightly
fi
export TF_CPP_MIN_LOG_LEVEL=0
export TD_GET_DEFAULTS_TO_NONE=1


bash .github/unittest/linux_olddeps/scripts_gym_0_13/setup_env.sh
Expand Down Expand Up @@ -149,6 +185,7 @@ jobs:

echo "PYTHON_VERSION: $PYTHON_VERSION"
echo "CU_VERSION: $CU_VERSION"
export TD_GET_DEFAULTS_TO_NONE=1

## setup_env.sh
bash .github/unittest/linux_optdeps/scripts/run_all.sh
Expand Down Expand Up @@ -187,6 +224,7 @@ jobs:

echo "PYTHON_VERSION: $PYTHON_VERSION"
echo "CU_VERSION: $CU_VERSION"
export TD_GET_DEFAULTS_TO_NONE=1

## setup_env.sh
bash .github/unittest/linux/scripts/run_all.sh
1 change: 1 addition & 0 deletions .github/workflows/test-windows-optdepts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
export RELEASE=0
export TORCH_VERSION=nightly
fi
export TD_GET_DEFAULTS_TO_NONE=1

## setup_env.sh
./.github/unittest/windows_optdepts/scripts/setup_env.sh
Expand Down
Loading