Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] done = done | truncated in collector #2333

Merged
merged 2 commits into from
Jul 29, 2024
Merged

[BugFix] done = done | truncated in collector #2333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13e97e
[BugFix] `done = done | truncated` in collector
vmoens Jul 29, 2024
57e4051
amend
vmoens Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchrl/collectors/collectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,7 +1121,8 @@ def _maybe_set_truncated(self, final_rollout):
truncated = final_rollout["next", truncated_key]
truncated[last_step] = True
final_rollout["next", truncated_key] = truncated
final_rollout["next", _replace_last(truncated_key, "done")] = truncated
done = final_rollout["next", _replace_last(truncated_key, "done")]
final_rollout["next", _replace_last(truncated_key, "done")] = done | truncated
return final_rollout

@torch.no_grad()
Expand Down
Loading