Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versioning] v0.5 bump #2267

Merged
merged 29 commits into from
Jul 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
vmoens committed Jul 9, 2024
commit 0334ca5f7b434a8ca0666116855bc06a6d41014d
4 changes: 2 additions & 2 deletions test/test_libs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ def test_gym_gymnasium_parallel(self, maybe_fork_ParallelEnv):
def test_vecenvs_nan(self): # noqa: F811
# old versions of gym must return nan for next values when there is a done state
torch.manual_seed(0)
env = GymEnv("CartPole-v0", num_envs=2, device="cpu")
env = GymEnv("CartPole-v0", num_envs=2)
env.set_seed(0)
rollout = env.rollout(200)
assert torch.isfinite(rollout.get("observation")).all()
Expand All @@ -1110,7 +1110,7 @@ def test_vecenvs_nan(self): # noqa: F811
del env

# same with collector
env = GymEnv("CartPole-v0", num_envs=2) # , device="cpu")
env = GymEnv("CartPole-v0", num_envs=2)
env.set_seed(0)
c = SyncDataCollector(
env, RandomPolicy(env.action_spec), total_frames=2000, frames_per_batch=200
Expand Down
Loading