Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ActionDiscretizer #2247

Merged
merged 4 commits into from
Jun 26, 2024
Merged

[Feature] ActionDiscretizer #2247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66f86cf
amend
vmoens Jun 25, 2024
a0d3d20
amend
vmoens Jun 25, 2024
9a48b5c
Merge remote-tracking branch 'origin/main' into action-discretizer
vmoens Jun 26, 2024
7d1f59a
amend
vmoens Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
@vmoens
vmoens committed Jun 25, 2024
commit a0d3d20cda0268543f59d9ea95845c6b69f9e00f
4 changes: 3 additions & 1 deletion test/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11059,8 +11059,10 @@ def test_transform_compose(self):
],
)
def test_transform_env(self, envname, interval_as_tensor, categorical, sampling):
device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
base_env = GymEnv(
HALFCHEETAH_VERSIONED() if envname == "cheetah" else PENDULUM_VERSIONED()
HALFCHEETAH_VERSIONED() if envname == "cheetah" else PENDULUM_VERSIONED(),
device=device,
)
if interval_as_tensor:
num_intervals = torch.arange(5, 11 if envname == "cheetah" else 6)
Expand Down
7 changes: 5 additions & 2 deletions torchrl/envs/transforms/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8283,7 +8283,10 @@ def __init__(
super().__init__(in_keys_inv=[action_key], out_keys_inv=[out_action_key])
self.action_key = action_key
self.out_action_key = out_action_key
self.num_intervals = num_intervals
if not isinstance(num_intervals, torch.Tensor):
self.num_intervals = num_intervals
else:
self.register_buffer("num_intervals", num_intervals)
if sampling is None:
sampling = self.SamplingStrategy.MEDIAN
self.sampling = sampling
Expand Down Expand Up @@ -8397,7 +8400,7 @@ def custom_arange(nint):
del input_spec["full_action_spec", self.in_keys_inv[0]]
return input_spec
except Exception as err:
print("here!")
# To avoid silent AttributeErrors
raise RuntimeError(str(err))

def _init(self):
Expand Down
Loading