Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Jumanji from_pixels=True #2129

Merged
merged 9 commits into from
Apr 30, 2024
Merged

[Feature] Jumanji from_pixels=True #2129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99f4651
init
vmoens Apr 29, 2024
363d8c5
amend
vmoens Apr 29, 2024
700e92a
amend
vmoens Apr 29, 2024
a9c6be6
amend
vmoens Apr 29, 2024
fdda92a
amend
vmoens Apr 29, 2024
418d2b8
amend
vmoens Apr 29, 2024
ca337e5
amend
vmoens Apr 29, 2024
46c0ce1
lint
vmoens Apr 29, 2024
9210872
Merge remote-tracking branch 'origin/main' into fix-jumanji
vmoens Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
@vmoens
vmoens committed Apr 29, 2024
commit ca337e59c3b376131664a53f4416e984da93ee89
8 changes: 4 additions & 4 deletions .github/unittest/linux_libs/scripts_jumanji/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ git submodule sync && git submodule update --init --recursive
printf "Installing PyTorch with cu121"
if [[ "$TORCH_VERSION" == "nightly" ]]; then
if [ "${CU_VERSION:-}" == cpu ] ; then
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu -U
pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu -U
else
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121 -U
pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu121 -U
fi
elif [[ "$TORCH_VERSION" == "stable" ]]; then
if [ "${CU_VERSION:-}" == cpu ] ; then
pip3 install torch --index-url https://download.pytorch.org/whl/cpu
pip3 install torch torchvision --index-url https://download.pytorch.org/whl/cpu
else
pip3 install torch --index-url https://download.pytorch.org/whl/cu121
pip3 install torch torchvision --index-url https://download.pytorch.org/whl/cu121
fi
else
printf "Failed to install pytorch"
Expand Down
11 changes: 7 additions & 4 deletions torchrl/envs/libs/jumanji.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import numpy as np
import torch
import torchvision.transforms.v2.functional
from packaging import version
from tensordict import TensorDict, TensorDictBase

Expand Down Expand Up @@ -542,9 +541,13 @@ def render(
import jax
import jax.numpy as jnp
import jumanji
import matplotlib
import matplotlib.pyplot as plt
import PIL
try:
import matplotlib
import matplotlib.pyplot as plt
import PIL
import torchvision.transforms.v2.functional
except ImportError as err:
raise ImportError("Rendering with Jumanji requires torchvision, matplotlib and PIL to be installed.") from err

if matplotlib_backend is not None:
matplotlib.use(matplotlib_backend)
Expand Down
Loading