Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix multiple context syntax in multiagent examples #1943

Merged
merged 2 commits into from
Feb 21, 2024
+6 −5
Merged

[BugFix] Fix multiple context syntax in multiagent examples #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ae942c
amend
matteobettini Feb 21, 2024
693812e
amend
matteobettini Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/multiagent/iql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def train(cfg: "DictConfig"): # noqa: F821
and cfg.logger.backend
):
evaluation_start = time.time()
with torch.no_grad() and set_exploration_type(ExplorationType.MEAN):
with torch.no_grad(), set_exploration_type(ExplorationType.MODE):
env_test.frames = []
rollouts = env_test.rollout(
max_steps=cfg.env.max_steps,
Expand Down
2 changes: 1 addition & 1 deletion examples/multiagent/maddpg_iddpg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def train(cfg: "DictConfig"): # noqa: F821
and cfg.logger.backend
):
evaluation_start = time.time()
with torch.no_grad() and set_exploration_type(ExplorationType.MEAN):
with torch.no_grad(), set_exploration_type(ExplorationType.MODE):
env_test.frames = []
rollouts = env_test.rollout(
max_steps=cfg.env.max_steps,
Expand Down
3 changes: 2 additions & 1 deletion examples/multiagent/mappo_ippo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from torchrl.data.replay_buffers.storages import LazyTensorStorage
from torchrl.envs import RewardSum, TransformedEnv
from torchrl.envs.libs.vmas import VmasEnv
from torchrl.envs.utils import ExplorationType, set_exploration_type
from torchrl.modules import ProbabilisticActor, TanhNormal, ValueOperator
from torchrl.modules.models.multiagent import MultiAgentMLP
from torchrl.objectives import ClipPPOLoss, ValueEstimators
Expand Down Expand Up @@ -235,7 +236,7 @@ def train(cfg: "DictConfig"): # noqa: F821
and cfg.logger.backend
):
evaluation_start = time.time()
with torch.no_grad():
with torch.no_grad(), set_exploration_type(ExplorationType.MODE):
env_test.frames = []
rollouts = env_test.rollout(
max_steps=cfg.env.max_steps,
Expand Down
2 changes: 1 addition & 1 deletion examples/multiagent/qmix_vdn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def train(cfg: "DictConfig"): # noqa: F821
and cfg.logger.backend
):
evaluation_start = time.time()
with torch.no_grad() and set_exploration_type(ExplorationType.MEAN):
with torch.no_grad(), set_exploration_type(ExplorationType.MODE):
env_test.frames = []
rollouts = env_test.rollout(
max_steps=cfg.env.max_steps,
Expand Down
2 changes: 1 addition & 1 deletion examples/multiagent/sac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def train(cfg: "DictConfig"): # noqa: F821
and cfg.logger.backend
):
evaluation_start = time.time()
with torch.no_grad() and set_exploration_type(ExplorationType.MODE):
with torch.no_grad(), set_exploration_type(ExplorationType.MODE):
env_test.frames = []
rollouts = env_test.rollout(
max_steps=cfg.env.max_steps,
Expand Down