Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix update in serial / parallel env #1866

Merged
merged 35 commits into from
Feb 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
vmoens committed Feb 4, 2024
commit 7bd6dc059fc293fa8c0d5985a55a06c6acb05a42
25 changes: 15 additions & 10 deletions torchrl/envs/batched_envs.py
Original file line number Diff line number Diff line change
Expand Up @@ -535,22 +535,17 @@ def _create_td(self) -> None:
self._selected_keys = self._selected_keys.union(reset_keys)

# input keys
self._selected_input_keys = {
unravel_key(key) for key in self._env_input_keys
}
self._selected_input_keys = {unravel_key(key) for key in self._env_input_keys}
# output keys after reset
self._selected_reset_keys = {
unravel_key(key)
for key in self._env_obs_keys + self.done_keys + reset_keys
unravel_key(key) for key in self._env_obs_keys + self.done_keys + reset_keys
}
# output keys after reset, filtered
self._selected_reset_keys_filt = {
unravel_key(key) for key in self._env_obs_keys + self.done_keys
}
# output keys after step
self._selected_step_keys = {
unravel_key(key) for key in self._env_output_keys
}
self._selected_step_keys = {unravel_key(key) for key in self._env_output_keys}

if self._single_task:
shared_tensordict_parent = shared_tensordict_parent.select(
Expand Down Expand Up @@ -1170,8 +1165,18 @@ def step_and_maybe_reset(
next_td = next_td.clone()
tensordict_ = tensordict_.clone()
elif device is not None:
next_td = next_td.apply(lambda x: x.to(device, non_blocking=True) if x.device != device else x.clone(), device=device)
tensordict_ = tensordict_.apply(lambda x: x.to(device, non_blocking=True) if x.device != device else x.clone(), device=device)
next_td = next_td._fast_apply(
lambda x: x.to(device, non_blocking=True)
if x.device != device
else x.clone(),
device=device,
)
tensordict_ = tensordict_._fast_apply(
lambda x: x.to(device, non_blocking=True)
if x.device != device
else x.clone(),
device=device,
)
else:
next_td = next_td.clone().clear_device_()
tensordict_ = tensordict_.clone().clear_device_()
Expand Down
Loading