Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Logger #1858

Merged
merged 49 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
012f9c0
init
vmoens Jan 19, 2024
3485d6d
Merge remote-tracking branch 'origin/main' into remove-deprecs
vmoens Jan 31, 2024
b1344e6
Merge remote-tracking branch 'origin/main' into remove-deprecs
vmoens Jan 31, 2024
4839c09
amend
vmoens Jan 31, 2024
95ac71d
amend
vmoens Jan 31, 2024
067f4da
Merge remote-tracking branch 'origin/main' into remove-deprecs
vmoens Jan 31, 2024
e31e41b
amend
vmoens Jan 31, 2024
d7d2621
amend
vmoens Jan 31, 2024
f5b195d
amend
vmoens Jan 31, 2024
96d3a18
amend
vmoens Jan 31, 2024
4b41b5c
amend
vmoens Jan 31, 2024
755b7f4
amend
vmoens Jan 31, 2024
4b8c89b
amend
vmoens Jan 31, 2024
2fc17c2
amend
vmoens Jan 31, 2024
ba8dada
amend
vmoens Jan 31, 2024
3120f22
amend
vmoens Jan 31, 2024
ff27094
amend
vmoens Jan 31, 2024
6bdb2c4
amend
vmoens Jan 31, 2024
5dbc588
init
vmoens Jan 31, 2024
f30e02a
amend
vmoens Jan 31, 2024
b1c69b1
amend
vmoens Jan 31, 2024
ab07abe
amend
vmoens Jan 31, 2024
c7e8278
amend
vmoens Jan 31, 2024
f984105
amend
vmoens Jan 31, 2024
deb8b2e
amend
vmoens Jan 31, 2024
d0efa38
Merge remote-tracking branch 'origin/remove-deprecs' into logger
vmoens Jan 31, 2024
62b1dc8
amend
vmoens Jan 31, 2024
bd498ab
amend
vmoens Jan 31, 2024
b35c26a
Merge branch 'remove-deprecs' into logger
vmoens Jan 31, 2024
bf4a0d9
amend
vmoens Jan 31, 2024
1903d10
Merge branch 'remove-deprecs' into logger
vmoens Jan 31, 2024
e4bdde2
amend
vmoens Jan 31, 2024
ba63298
Merge remote-tracking branch 'origin/main' into logger
vmoens Jan 31, 2024
9c36712
amend
vmoens Jan 31, 2024
fdc4557
amend
vmoens Jan 31, 2024
c8d6441
amend
vmoens Jan 31, 2024
f32ce83
amend
vmoens Jan 31, 2024
f68dd4f
amend
vmoens Jan 31, 2024
2c2c9fb
amend
vmoens Jan 31, 2024
31b866a
amend
vmoens Jan 31, 2024
656e75b
amend
vmoens Jan 31, 2024
22cd51b
empty
vmoens Jan 31, 2024
23171f7
amend
vmoens Jan 31, 2024
707747e
amend
vmoens Jan 31, 2024
f44fe53
amend
vmoens Jan 31, 2024
2c737d6
amend
vmoens Jan 31, 2024
2797de8
amend
vmoens Jan 31, 2024
03c201c
amend
vmoens Jan 31, 2024
4b746f6
amend
vmoens Jan 31, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
vmoens committed Jan 31, 2024
commit f68dd4faa34f8396f94041ff25c594bc2482b957
2 changes: 1 addition & 1 deletion .github/unittest/linux_examples/scripts/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ python .github/unittest/helpers/coverage_run_parallel.py examples/multiagent/iql
collector.frames_per_batch=200 \
train.num_epochs=3 \
train.minibatch_size=100 \
logger.backend=
logger.backendg
python .github/unittest/helpers/coverage_run_parallel.py examples/multiagent/qmix_vdn.py \
collector.n_iters=2 \
collector.frames_per_batch=200 \
Expand Down
4 changes: 2 additions & 2 deletions examples/td3/td3.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
make_replay_buffer,
make_td3_agent,
)

from torchrl._utils import logger as torchrl_logger

@hydra.main(version_base="1.1", config_path=".", config_name="config")
def main(cfg: "DictConfig"): # noqa: F821
Expand Down Expand Up @@ -206,7 +206,7 @@ def main(cfg: "DictConfig"): # noqa: F821
collector.shutdown()
end_time = time.time()
execution_time = end_time - start_time
logger.info(f"Training took {execution_time:.2f} seconds to finish")
torchrl_logger.info(f"Training took {execution_time:.2f} seconds to finish")


if __name__ == "__main__":
Expand Down
Loading