Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multi-env / multiprocessing seeding logic to make it uncorrelated across runs #182

Merged
merged 15 commits into from
Jun 7, 2022
Merged

Refactor multi-env / multiprocessing seeding logic to make it uncorrelated across runs #182

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7545721
add seed generator and unit test
May 27, 2022
f3970a8
address comments
Jun 6, 2022
086fdba
fix logic error
Jun 6, 2022
860a8da
remove unused lines
Jun 6, 2022
5effdc1
fix mock envs
vmoens Jun 6, 2022
2dc4537
fix test_rollout_predictability
vmoens Jun 6, 2022
542380d
add seed generator and unit test
May 27, 2022
14ae74a
address comments
Jun 6, 2022
2fb8eb8
fix logic error
Jun 6, 2022
097fe87
remove unused lines
Jun 6, 2022
5820c50
fix mock envs
vmoens Jun 6, 2022
5a8241e
fix test_rollout_predictability
vmoens Jun 6, 2022
abe7d5e
Merge remote-tracking branch 'origin/main' into 129_enhance_multiproc…
vmoens Jun 6, 2022
485cfdb
Merge remote-tracking branch 'hojin/129_enhance_multiprocessing_seedi…
vmoens Jun 6, 2022
78e41e4
move seed generating logic to base env
Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused lines
  • Loading branch information
Hojin committed Jun 6, 2022
commit 097fe8772b6eb9d026c20f776efb777ecae242ec
9 changes: 0 additions & 9 deletions torchrl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,6 @@ def _check_for_faulty_process(processes):
)


# def seed_generator(seed, repeat):
# max_seed_val = (
# 2 ** 32 - 1
# ) # https://discuss.pytorch.org/t/what-is-the-max-seed-you-can-set-up/145688
# rng = np.random.default_rng(seed)
# for i in range(repeat):
# yield int.from_bytes(rng.bytes(8), "big") % max_seed_val


def seed_generator(seed):
max_seed_val = (
2 ** 32 - 1
Expand Down