Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Algorithm] Discrete IQL #1793

Merged
merged 10 commits into from
Jan 16, 2024
Merged

[Algorithm] Discrete IQL #1793

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8d7164e
fixes
BY571 Jan 12, 2024
2231a69
add tests
BY571 Jan 12, 2024
1dbd9d1
fix
BY571 Jan 12, 2024
4e802dc
fix expectile check
BY571 Jan 15, 2024
50daaf4
reshape-view change
BY571 Jan 15, 2024
27d8eef
update test names
BY571 Jan 15, 2024
bcab872
update docs
BY571 Jan 15, 2024
710106c
Update docs/source/reference/objectives.rst
vmoens Jan 15, 2024
1e467ac
offlinerl batch to device
BY571 Jan 16, 2024
65746f2
Merge branch 'discrete_online_iql' of https://github.com/BY571/rl int…
BY571 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix expectile check
  • Loading branch information
@BY571
BY571 committed Jan 15, 2024
commit 4e802dca24dcbc17e293c4d4b85fbd0f3d8eed09
2 changes: 1 addition & 1 deletion torchrl/objectives/iql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ def __init__(
) -> None:
self._in_keys = None
self._out_keys = None
if expectile < 1.0:
if expectile >= 1.0:
raise ValueError(f"Expectile should be lower than 1.0 but is {expectile}")
super().__init__(
actor_network=actor_network,
Expand Down