Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix windows CI #1746

Merged
merged 29 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
no more rlenv
  • Loading branch information
vmoens committed Dec 18, 2023
commit e923d2d60a807c8a10ce7089f913aabee8f35757
4 changes: 2 additions & 2 deletions .github/unittest/windows_optdepts/scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ set -ex

this_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

eval "$(${conda_dir}/Scripts/conda.exe 'shell.bash' 'hook')"
conda activate rlenv
eval "$(./conda/Scripts/conda.exe 'shell.bash' 'hook')"
conda activate ./env

# TODO, refactor the below logic to make it easy to understand how to get correct cuda_version.
if [ "${CU_VERSION:-}" == cpu ] ; then
Expand Down
7 changes: 3 additions & 4 deletions .github/unittest/windows_optdepts/scripts/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@

set -e

this_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

eval "$(${conda_dir}/Scripts/conda.exe 'shell.bash' 'hook')"
conda activate rlenv
eval "$(./conda/Scripts/conda.exe 'shell.bash' 'hook')"
conda activate ./env

this_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
source "$this_dir/set_cuda_envs.sh"

python -m torch.utils.collect_env
Expand Down
4 changes: 2 additions & 2 deletions .github/unittest/windows_optdepts/scripts/setup_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ eval "$(${conda_dir}/Scripts/conda.exe 'shell.bash' 'hook')"

# 2. Create test environment at ./env
printf "* Creating a test environment\n"
conda create -n rlenv -y python="$PYTHON_VERSION"
conda create --prefix "${env_dir}" -y python="$PYTHON_VERSION"

printf "* Activating the environment"
conda deactivate
conda activate rlenv
conda activate "${env_dir}"

printf "Python version"
echo $(which python)
Expand Down
Loading