Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] DDPG extra critic input tests #1568

Merged
merged 7 commits into from
Sep 24, 2023
Merged

[Tests] DDPG extra critic input tests #1568

merged 7 commits into from
Sep 24, 2023

Conversation

matteobettini
Copy link
Contributor

Tests accompanying the fix of #1563

@matteobettini
init
72d6d4b 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
init
8f280af 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
init
5a8b9cb 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
init
e45f301 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
amend
4cdcea3 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
amend
504b63b 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
Merge branch 'main' into fix_critic_input
8bde6bc
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2023
@matteobettini matteobettini added the Tests Incomplete or broken unit tests label Sep 22, 2023
vmoens
vmoens approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 434fe58 into pytorch:main Sep 24, 2023
@matteobettini matteobettini deleted the fix_critic_input branch September 25, 2023 10:43
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@matteobettini @vmoens
[Tests] DDPG extra critic input tests (pytorch#1568)
d115036 
Signed-off-by: Matteo Bettini <matbet@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot