-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Algorithm] Update DQN example #1512
Merged
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
32262e3
cartpole
albertbou92 7e44e5b
atari
albertbou92 4641561
cartpole
albertbou92 8ad0fc1
fix
albertbou92 f4359e1
Merge remote-tracking branch 'origin/main' into update_dqn_example
vmoens ece9522
hydra config cartpole
albertbou92 51b673a
fix
albertbou92 6de66ed
fixes
vmoens c673a31
Merge remote-tracking branch 'PyTorchRL/update_dqn_example' into upda…
vmoens d1dfc1b
Merge pull request #1 from vmoens/update_dqn_example
vmoens 617f9a3
params
albertbou92 7b3e6a4
params
albertbou92 1b5d32d
params
albertbou92 7f57539
atari working script
albertbou92 8ea99b2
fix
albertbou92 d81504a
vecnorm
albertbou92 2a27d09
conf
albertbou92 43596ee
fix
albertbou92 b20f756
eval time
albertbou92 fa5a03a
original implementation
albertbou92 c7b9255
logging
albertbou92 3e3d7d0
format
albertbou92 fc63456
fix
albertbou92 0e0e401
Merge branch 'main' into update_dqn_example
albertbou92 ef6d5f6
cleaner scripts
albertbou92 441a67e
cleaner scripts
albertbou92 75389db
fix
albertbou92 d9d35d1
fix
albertbou92 fa95119
format
albertbou92 206ee3c
format
albertbou92 d552d98
Merge branch 'main' into update_dqn_example
albertbou92 0a7818f
env reader and merge main
albertbou92 108e8fa
fix
albertbou92 673e7dd
eol transform
albertbou92 5089ca8
fixes
albertbou92 f805db1
Merge branch 'main' into update_dqn_example
albertbou92 048a8df
introduce feedback
albertbou92 c981e22
script fixes
albertbou92 1d961bb
Merge branch 'main' into update_dqn_example
albertbou92 c099b31
script fixes
albertbou92 4cbffa9
script fixes
albertbou92 02d6c34
script fixes
albertbou92 a488404
script fixes
albertbou92 36e3076
script fixes
albertbou92 f7c9bc6
fixes
albertbou92 0fdd264
fixes
albertbou92 a6a8d6e
fixes
albertbou92 de19aed
fixes
albertbou92 68b7a19
fixes
albertbou92 af4c603
Merge branch 'main' into update_dqn_example
albertbou92 807d9c5
Merge branch 'main' into update_dqn_example
albertbou92 197b679
atari tqdm fix
albertbou92 d61b160
Merge remote-tracking branch 'origin/main' into update_dqn_example
vmoens d739a80
Merge branch 'update_dqn_example' of https://github.com/PyTorchRL/rl …
vmoens a249366
Merge branch 'main' into update_dqn_example
03a3a62
merge main
53714c0
merge main
6b60324
atari script
albertbou92 06cc740
fixes
vmoens 75625bd
fix end-of-life
vmoens 82e253e
device in conf
albertbou92 014cc62
skip initial collection frames
albertbou92 fb6f61a
move logging
albertbou92 2346870
move logging
albertbou92 03bc5b0
Merge remote-tracking branch 'origin/main' into update_dqn_example
vmoens 97e7aa5
CI examples fix
albertbou92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
hydra config cartpole
- Loading branch information
commit ece9522208dba32fad3d5f620e385aaa0923ef6b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Environment | ||
env: | ||
env_name: CartPole-v1 | ||
|
||
# collector | ||
collector: | ||
total_frames: 500_000 | ||
frames_per_batch: 10 | ||
eps_start: 1.0 | ||
eps_end: 0.05 | ||
annealing_frames: 250_000 | ||
init_random_frames: 10_000 | ||
|
||
# buffer | ||
buffer: | ||
buffer_size: 10_000 | ||
batch_size: 128 | ||
|
||
# logger | ||
logger: | ||
backend: csv | ||
exp_name: DQN | ||
|
||
# Optim | ||
optim: | ||
lr: 2.5e-4 | ||
|
||
# loss | ||
loss: | ||
gamma: 0.99 | ||
hard_update_freq: 1 | ||
num_updates: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmarks in the repo is intended for runtime benchmark.
I would call this evaluation. At the end of the day, I think that what we will want is the following directory tree:
cc @matteobettini @BY571