Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] step_mdp nested keys #1339

Merged
merged 17 commits into from
Jun 30, 2023
Merged

[BugFix] step_mdp nested keys #1339

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8271709
new nested step_mdp test
matteobettini Jun 30, 2023
123fe5c
step_mdp starting from out
matteobettini Jun 30, 2023
9fcf81b
step_mdp starting from next
matteobettini Jun 30, 2023
07dc9bb
remove action exclusion from next
matteobettini Jun 30, 2023
88b53f0
more tests
matteobettini Jun 30, 2023
3953501
Merge branch 'main' into step_mdp_nested
matteobettini Jun 30, 2023
cb46165
undo step_mdp changes
matteobettini Jun 30, 2023
637fc22
mic drop
matteobettini Jun 30, 2023
1fdd419
Merge branch 'main' into step_mdp_nested
matteobettini Jun 30, 2023
64e51f7
clone without keys
matteobettini Jun 30, 2023
16e5c41
test
matteobettini Jun 30, 2023
7927514
lock
matteobettini Jun 30, 2023
ba0d593
excluded iteratively
matteobettini Jun 30, 2023
a3bd68b
amend
matteobettini Jun 30, 2023
4a38252
amend
matteobettini Jun 30, 2023
4b71050
fix
matteobettini Jun 30, 2023
a501be6
fix
matteobettini Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
excluded iteratively 
Signed-off-by: Matteo Bettini <matbet@meta.com>
  • Loading branch information
@matteobettini
matteobettini committed Jun 30, 2023
commit ba0d59376ff8d649455677a6a1666fa304938984
9 changes: 5 additions & 4 deletions torchrl/envs/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,11 @@ def step_mdp(
)

# Set the keys from next
excluded = {
done_key if exclude_done else None,
reward_key if exclude_reward else None,
}
excluded = set()
if exclude_done:
excluded.add(done_key)
if exclude_reward:
excluded.add(reward_key)
for key in td_next_keys:
if key not in excluded:
_set_key(dest=out, source=td_next, key=key)
Expand Down