Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] re-enable test_Conv2d_groups_nobias tests #75008

Closed
wants to merge 1 commit into from

Conversation

KyleCZH
Copy link
Contributor

@KyleCZH KyleCZH commented Mar 31, 2022

fixes:
#59158
#58701

Signed-off-by: Kyle Chen <kylechen@amd.com>
@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Mar 31, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 31, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit f0ddd69 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See GitHub Actions build pull / linux-xenial-py3.7-clang7-asan / test (default, 2, 3, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

2022-03-31T10:52:36.3622955Z unknown file: Failure
2022-03-31T10:52:35.6741305Z �[0;32m[       OK ] �[mKernel.CatInputTypesPromotion (65 ms)
2022-03-31T10:52:35.6741783Z �[0;32m[ RUN      ] �[mKernel.CatAndInlineWithAConstantDim
2022-03-31T10:52:36.0240806Z �[0;32m[       OK ] �[mKernel.CatAndInlineWithAConstantDim (349 ms)
2022-03-31T10:52:36.0241187Z �[0;32m[ RUN      ] �[mKernel.CatWithEmptyInputs
2022-03-31T10:52:36.2349096Z �[0;32m[       OK ] �[mKernel.CatWithEmptyInputs (210 ms)
2022-03-31T10:52:36.2349525Z �[0;32m[ RUN      ] �[mKernel.CatWoConditionals
2022-03-31T10:52:36.2978187Z �[0;32m[       OK ] �[mKernel.CatWoConditionals (62 ms)
2022-03-31T10:52:36.2978516Z �[0;32m[ RUN      ] �[mKernel.OptimizeConditionals
2022-03-31T10:52:36.3510727Z �[0;32m[       OK ] �[mKernel.OptimizeConditionals (53 ms)
2022-03-31T10:52:36.3511011Z �[0;32m[ RUN      ] �[mKernel.Stack
2022-03-31T10:52:36.3622955Z unknown file: Failure
2022-03-31T10:52:36.3623405Z C++ exception with description "Expected to not find "\n" but found it
2022-03-31T10:52:36.3623869Z       for (int64_t k = 0ll; k < 2ll; k++) {
2022-03-31T10:52:36.3624078Z         for (int64_t l = 0ll; l < 3ll; l++) {
2022-03-31T10:52:36.3626545Z           for (int64_t m = 0ll; m < 6ll; m++) {
2022-03-31T10:52:36.3627017Z             aten_stack[(((108ll * i + 18ll * k) + m) + 36ll * j) + 6ll * l] = k==1ll ? (ty_1[((18ll * j + m) + 54ll * i) + 6ll * l]) : (tx_1[((18ll * j + m) + 54ll * i) + 6ll * l]);
2022-03-31T10:52:36.3627288Z           }
2022-03-31T10:52:36.3627451Z         }
2022-03-31T10:52:36.3627718Z From CHECK-NEXT: aten_stack
2022-03-31T10:52:36.3627922Z " thrown in the test body.
2022-03-31T10:52:36.3628192Z �[0;31m[  FAILED  ] �[mKernel.Stack (11 ms)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@KyleCZH KyleCZH marked this pull request as ready for review March 31, 2022 15:56
@KyleCZH
Copy link
Contributor Author

KyleCZH commented Mar 31, 2022

CI builds are passing after tests are enabled. @jithunnair-amd @jeffdaily

@dagitses dagitses requested review from jbschlosser and albanD April 1, 2022 14:48
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 1, 2022
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albanD
Copy link
Collaborator

albanD commented Apr 1, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Hey @KyleCZH.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@albanD albanD added the topic: not user facing topic category label Apr 1, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
Summary:
fixes:
#59158
#58701

Pull Request resolved: #75008
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f888dc584214948e9048070d3ba972d5df776846

Reviewed By: atalman

Differential Revision: D35359967

fbshipit-source-id: 2ed62725d0fe3eec29b504070ec2450d2fd2a5f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants