Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Enable support for roll() op. (#58389) #58697

Closed
wants to merge 3 commits into from
Closed

[ONNX] Enable support for roll() op. (#58389) #58697

wants to merge 3 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 20, 2021 •
edited
Loading

Stack from ghstack:

  1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
  2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z jiz@microsoft.com

Differential Revision: D28714807

@fatcat-z @BowenBao
[ONNX] Enable support for roll() op. (#58389)
7cebc28 
1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z <jiz@microsoft.com>

[ghstack-poisoned]
This was referenced May 20, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 194df2c (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Lint / mypy (1/1)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-05-26T23:36:31.4396543Z torch/distributed/...e type Module; expected "Type[Module]" [arg-type] 
2021-05-26T23:35:37.9465650Z shell: /bin/bash -e {0}
2021-05-26T23:35:37.9465966Z env:
2021-05-26T23:35:37.9466435Z   pythonLocation: /opt/hostedtoolcache/Python/3.8.10/x64
2021-05-26T23:35:37.9467048Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.10/x64/lib
2021-05-26T23:35:37.9467513Z ##[endgroup]
2021-05-26T23:35:37.9531425Z + for CONFIG in mypy*.ini
2021-05-26T23:35:37.9532446Z + mypy --config=mypy-strict.ini
2021-05-26T23:35:54.5000267Z Success: no issues found in 81 source files
2021-05-26T23:35:55.1539157Z + for CONFIG in mypy*.ini
2021-05-26T23:35:55.1540138Z + mypy --config=mypy.ini
2021-05-26T23:36:31.4396543Z torch/distributed/nn/api/remote_module.py:525:41: error: Argument 2 to "__init__" of "_RemoteModule" has incompatible type Module; expected "Type[Module]"  [arg-type]
2021-05-26T23:37:06.6912378Z Found 1 error in 1 file (checked 1354 source files)
2021-05-26T23:37:08.6808005Z ##[error]Process completed with exit code 1.
2021-05-26T23:37:08.6905274Z Post job cleanup.
2021-05-26T23:37:08.7886747Z [command]/usr/bin/git version
2021-05-26T23:37:08.7946082Z git version 2.31.1
2021-05-26T23:37:08.7990130Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-05-26T23:37:08.8028787Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-05-26T23:37:08.8275593Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-05-26T23:37:08.8312232Z http.https://github.com/.extraheader
2021-05-26T23:37:08.8322484Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

BowenBao pushed a commit that referenced this pull request May 20, 2021
@fatcat-z @BowenBao
[ONNX] Enable support for roll() op. (#58389)
3fe584f 
1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z <jiz@microsoft.com>

ghstack-source-id: 0cc09ce31e92a08dbd66af952d47b07f5199f5b5
Pull Request resolved: #58697
@BowenBao
Update on "[ONNX] Enable support for roll() op. (#58389)"
38c819b 
1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z <jiz@microsoft.com>

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request May 20, 2021
@BowenBao
[ONNX] Enable support for roll() op. (#58389)
bf3fae8 
1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z <jiz@microsoft.com>

ghstack-source-id: 197d52d3b0cb81b5f523b5f8235dd8326698a54d
Pull Request resolved: #58697
@BowenBao BowenBao mentioned this pull request May 21, 2021
Closed
@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@BowenBao
Update on "[ONNX] Enable support for roll() op. (#58389)"
194df2c 
1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z <jiz@microsoft.com>

Differential Revision: [D28714807](https://our.internmc.facebook.com/intern/diff/D28714807)

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request May 26, 2021
@BowenBao
[ONNX] Enable support for roll() op. (#58389)
2720b54 
1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Co-authored-by: fatcat-z <jiz@microsoft.com>

ghstack-source-id: 5b294c4c92ae6b37cc5384537e23a80428a860a5
Pull Request resolved: #58697
@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in 2c17b6a.

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/79/head branch May 31, 2021 14:17
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@BowenBao @fatcat-z @deniskokarev
[ONNX] Enable support for roll() op. (pytorch#58389) (pytorch#58697)
35c7d86 
Summary:
Pull Request resolved: pytorch#58697

1. Add a symbolic function for aten::roll() op in symbolic_opset9.py.
2. Add a test with multiple scenarios as well.

Test Plan: Imported from OSS

Reviewed By: driazati, bhosmer

Differential Revision: D28714807

Pulled By: SplitInfinity

fbshipit-source-id: eae85f2dcf02737c9256a180f6905a935ca3f57e

Co-authored-by: fatcat-z <jiz@microsoft.com>
@garymm garymm mentioned this pull request Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neginraoof neginraoof Awaiting requested review from neginraoof

@spandantiwari spandantiwari Awaiting requested review from spandantiwari

Assignees
No one assigned
Labels
cla signed Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BowenBao @facebook-github-bot @SplitInfinity @pytorchbot @fatcat-z