[ONNX] use consistent quoting for string literals (#57757) #58695

BowenBao · 2021-05-20T20:21:15Z

Stack from ghstack:

[ONNX] Enable support for roll() op. (#58389) #58697 [ONNX] Enable support for roll() op. ([ONNX] Enable support for roll() op. #58389)
[ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias (#58317) #58696 [ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias ([ONNX] handle aten::_set_item on Dict in convertInplaceOpsAndTrackAlias #58317)
[ONNX] use consistent quoting for string literals (#57757) #58695 [ONNX] use consistent quoting for string literals ([ONNX] use consistent quoting for string literals #57757)
[ONNX] Improve lower tuples and handle control flow (#57650) #58694 [ONNX] Improve lower tuples and handle control flow ([ONNX] Improve lower tuples and handle control flow #57650)
[ONNX] Update special post process for SequenceInsert after SequenceEmpty (#56965) #58693 [ONNX] Update special post process for SequenceInsert after SequenceEmpty ([ONNX] Update special post process for SequenceInsert after SequenceEmpty #56965)
Support symbolic for conv_tbc (#58359) #58692 Support symbolic for conv_tbc (Support symbolic for conv_tbc #58359)
[ONNX] RNN scripting (#57564) #58691 [ONNX] RNN scripting ([ONNX] RNN scripting #57564)
[ONNX] Update instance_norm2 symbolic to handle track_running_stats=True (#55051) #58690 [ONNX] Update instance_norm2 symbolic to handle track_running_stats=True ([ONNX] Update instance_norm2 symbolic to handle track_running_stats=True #55051)

As PEP8 says: "Pick a rule and stick to it." [1]

[1] https://www.python.org/dev/peps/pep-0008/#string-quotes

Co-authored-by: Gary Miguel garymiguel@microsoft.com

Differential Revision: D28714811

As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Co-authored-by: Gary Miguel <garymiguel@microsoft.com> [ghstack-poisoned]

facebook-github-bot · 2021-05-20T20:21:27Z

💊 CI failures summary and remediations

As of commit f6e31db (more details on the Dr. CI page):

3/3 failures possibly* introduced in this PR
- 1/3 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

Lint / mypy (1/1)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-05-26T20:41:34.3190387Z torch/distributed/...e type Module; expected "Type[Module]" [arg-type]

2021-05-26T20:40:35.1000796Z shell: /bin/bash -e {0}
2021-05-26T20:40:35.1001184Z env:
2021-05-26T20:40:35.1001757Z   pythonLocation: /opt/hostedtoolcache/Python/3.8.10/x64
2021-05-26T20:40:35.1002885Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.10/x64/lib
2021-05-26T20:40:35.1003448Z ##[endgroup]
2021-05-26T20:40:35.1109171Z + for CONFIG in mypy*.ini
2021-05-26T20:40:35.1111938Z + mypy --config=mypy-strict.ini
2021-05-26T20:40:53.5941253Z Success: no issues found in 81 source files
2021-05-26T20:40:54.3109738Z + for CONFIG in mypy*.ini
2021-05-26T20:40:54.3113014Z + mypy --config=mypy.ini
2021-05-26T20:41:34.3190387Z torch/distributed/nn/api/remote_module.py:525:41: error: Argument 2 to "__init__" of "_RemoteModule" has incompatible type Module; expected "Type[Module]"  [arg-type]
2021-05-26T20:42:14.0644849Z Found 1 error in 1 file (checked 1354 source files)
2021-05-26T20:42:16.1733210Z ##[error]Process completed with exit code 1.
2021-05-26T20:42:16.1841005Z Post job cleanup.
2021-05-26T20:42:16.2904988Z [command]/usr/bin/git version
2021-05-26T20:42:16.2972133Z git version 2.31.1
2021-05-26T20:42:16.3019608Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-05-26T20:42:16.3062910Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-05-26T20:42:16.3341328Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-05-26T20:42:16.3375231Z http.https://github.com/.extraheader
2021-05-26T20:42:16.3385703Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader

1 failure not recognized by patterns:

Job	Step	Action
^{Windows CI (pytorch-win-vs2019-cpu-py3) / render_test_results}	^{Checkout PyTorch}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Co-authored-by: Gary Miguel <garymiguel@microsoft.com> [ghstack-poisoned]

SplitInfinity · 2021-05-22T03:33:53Z

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

SplitInfinity · 2021-05-26T17:30:25Z

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Co-authored-by: Gary Miguel <garymiguel@microsoft.com> Differential Revision: [D28714811](https://our.internmc.facebook.com/intern/diff/D28714811) [ghstack-poisoned]

SplitInfinity · 2021-05-26T21:27:48Z

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-05-27T19:07:14Z

@SplitInfinity merged this pull request in 0a6828a.

…torch#58695) Summary: Pull Request resolved: pytorch#58695 As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Test Plan: Imported from OSS Reviewed By: driazati Differential Revision: D28714811 Pulled By: SplitInfinity fbshipit-source-id: c95103aceb1725c17c034dc6fc8216627f189548 Co-authored-by: Gary Miguel <garymiguel@microsoft.com>

[ONNX] use consistent quoting for string literals (#57757)

eca525e

As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Co-authored-by: Gary Miguel <garymiguel@microsoft.com> [ghstack-poisoned]

BowenBao requested review from neginraoof and spandantiwari as code owners May 20, 2021 20:21

facebook-github-bot added the cla signed label May 20, 2021

pytorchbot added the open source label May 20, 2021

Update on "[ONNX] use consistent quoting for string literals (#57757)"

f00100d

As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Co-authored-by: Gary Miguel <garymiguel@microsoft.com> [ghstack-poisoned]

facebook-github-bot closed this in 0a6828a May 27, 2021

facebook-github-bot added the Merged label May 27, 2021

facebook-github-bot deleted the gh/BowenBao/77/head branch May 31, 2021 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] use consistent quoting for string literals (#57757) #58695

[ONNX] use consistent quoting for string literals (#57757) #58695

BowenBao commented May 20, 2021 •

edited

Loading

facebook-github-bot commented May 20, 2021 •

edited

Loading

SplitInfinity commented May 22, 2021

SplitInfinity commented May 26, 2021

SplitInfinity commented May 26, 2021

facebook-github-bot commented May 27, 2021

[ONNX] use consistent quoting for string literals (#57757) #58695

[ONNX] use consistent quoting for string literals (#57757) #58695

Conversation

BowenBao commented May 20, 2021 • edited Loading

facebook-github-bot commented May 20, 2021 • edited Loading

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

Lint / mypy (1/1)

1 failure not recognized by patterns:

SplitInfinity commented May 22, 2021

SplitInfinity commented May 26, 2021

SplitInfinity commented May 26, 2021

facebook-github-bot commented May 27, 2021

BowenBao commented May 20, 2021 •

edited

Loading

facebook-github-bot commented May 20, 2021 •

edited

Loading