Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Improve lower tuples and handle control flow (#57650) #58694

Closed
wants to merge 3 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 20, 2021

Stack from ghstack:

Improving the logic for finding tuple patterns within control flow.
Also fixes: #56914

Co-authored-by: neginraoof neginmr@utexas.edu

Differential Revision: D28714806

Improving the logic for finding tuple patterns within control flow.
Also fixes: #56914

Co-authored-by: neginraoof <neginmr@utexas.edu>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2021

💊 CI failures summary and remediations

As of commit b0a824f (more details on the Dr. CI page):


  • 6/6 failures possibly* introduced in this PR
    • 1/6 non-scanned failure(s)

5 failures not recognized by patterns:

Job Step Action
GitHub Actions Lint / quick-checks C++ docs check 🔁 rerun
GitHub Actions Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / calculate-docker-image Unknown 🔁 rerun
GitHub Actions Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / render_test_results Download PyTorch Test Reports 🔁 rerun
GitHub Actions Lint / flake8-py3 Upload artifact 🔁 rerun
GitHub Actions Lint / mypy Install dependencies 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Improving the logic for finding tuple patterns within control flow.
Also fixes: #56914

Co-authored-by: neginraoof <neginmr@utexas.edu>

[ghstack-poisoned]
@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Improving the logic for finding tuple patterns within control flow.
Also fixes: #56914

Co-authored-by: neginraoof <neginmr@utexas.edu>

Differential Revision: [D28714806](https://our.internmc.facebook.com/intern/diff/D28714806)

[ghstack-poisoned]
@SplitInfinity
Copy link

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in b27fc0f.

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/76/head branch May 31, 2021 14:17
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
…ytorch#58694)

Summary:
Pull Request resolved: pytorch#58694

Improving the logic for finding tuple patterns within control flow.
Also fixes: pytorch#56914

Test Plan: Imported from OSS

Reviewed By: driazati

Differential Revision: D28714806

Pulled By: SplitInfinity

fbshipit-source-id: 1552100cf9cc88e6f58df2e90758e8898ba0a9b3

Co-authored-by: neginraoof <neginmr@utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants