[ONNX] Update special post process for SequenceInsert after SequenceEmpty (#56965) #58693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty (#56965) `ONNX::SequenceEmpty` requires dtype to be provided, and is default to float. We updates previous dtype of created `ONNX::SequenceEmpty` node when dtype is later discovered to be other than float, through downstream `ONNX::SequenceInsert` node. This PR improves the algorithm to cover nested loop case. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 432ece9 (more details on the Dr. CI page):
7 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
This was referenced May 20, 2021
…r SequenceEmpty (#56965)" `ONNX::SequenceEmpty` requires dtype to be provided, and is default to float. We updates previous dtype of created `ONNX::SequenceEmpty` node when dtype is later discovered to be other than float, through downstream `ONNX::SequenceInsert` node. This PR improves the algorithm to cover nested loop case. Co-authored-by: BowenBao <bowbao@microsoft.com> [ghstack-poisoned]
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…r SequenceEmpty (#56965)" `ONNX::SequenceEmpty` requires dtype to be provided, and is default to float. We updates previous dtype of created `ONNX::SequenceEmpty` node when dtype is later discovered to be other than float, through downstream `ONNX::SequenceInsert` node. This PR improves the algorithm to cover nested loop case. Co-authored-by: BowenBao <bowbao@microsoft.com> Differential Revision: [D28714808](https://our.internmc.facebook.com/intern/diff/D28714808) [ghstack-poisoned]
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@SplitInfinity merged this pull request in 57c9355. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
…mpty (pytorch#56965) (pytorch#58693) Summary: Pull Request resolved: pytorch#58693 `ONNX::SequenceEmpty` requires dtype to be provided, and is default to float. We updates previous dtype of created `ONNX::SequenceEmpty` node when dtype is later discovered to be other than float, through downstream `ONNX::SequenceInsert` node. This PR improves the algorithm to cover nested loop case. Test Plan: Imported from OSS Reviewed By: driazati Differential Revision: D28714808 Pulled By: SplitInfinity fbshipit-source-id: e45ab3a12d0fec637733acbd3cd0438ff80d2cd4 Co-authored-by: BowenBao <bowbao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ONNX::SequenceEmptyrequires dtype to be provided, and is default to float. We updates previous dtype of createdONNX::SequenceEmptynode when dtype is later discovered to be other than float, through downstreamONNX::SequenceInsertnode. This PR improves the algorithm to cover nested loop case.Co-authored-by: BowenBao bowbao@microsoft.com
Differential Revision: D28714808