Support symbolic for conv_tbc (#58359) #58692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for exporting fairseq models, see: ```python model = torch.hub.load(github, 'conv.wmt14.en-fr', tokenizer='moses', bpe='subword_nmt') model = torch.hub.load(github, 'conv.wmt17.en-de', tokenizer='moses', bpe='subword_nmt') ``` With this fix, and comment out model script one line `GradMultiply`, these two models can be exported successfully with perf met. The original PR #57708 has merging issue, use this one instead. Co-authored-by: David <jiafa@microsoft.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit a00da05 (more details on the Dr. CI page):
3 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 20, 2021
This is a fix for exporting fairseq models, see: ```python model = torch.hub.load(github, 'conv.wmt14.en-fr', tokenizer='moses', bpe='subword_nmt') model = torch.hub.load(github, 'conv.wmt17.en-de', tokenizer='moses', bpe='subword_nmt') ``` With this fix, and comment out model script one line `GradMultiply`, these two models can be exported successfully with perf met. The original PR #57708 has merging issue, use this one instead. Co-authored-by: David <jiafa@microsoft.com> [ghstack-poisoned]
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This is a fix for exporting fairseq models, see: ```python model = torch.hub.load(github, 'conv.wmt14.en-fr', tokenizer='moses', bpe='subword_nmt') model = torch.hub.load(github, 'conv.wmt17.en-de', tokenizer='moses', bpe='subword_nmt') ``` With this fix, and comment out model script one line `GradMultiply`, these two models can be exported successfully with perf met. The original PR #57708 has merging issue, use this one instead. Co-authored-by: David <jiafa@microsoft.com> Differential Revision: [D28714809](https://our.internmc.facebook.com/intern/diff/D28714809) [ghstack-poisoned]
|
@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@SplitInfinity merged this pull request in b8c96e6. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#58692 This is a fix for exporting fairseq models, see: ```python model = torch.hub.load(github, 'conv.wmt14.en-fr', tokenizer='moses', bpe='subword_nmt') model = torch.hub.load(github, 'conv.wmt17.en-de', tokenizer='moses', bpe='subword_nmt') ``` With this fix, and comment out model script one line `GradMultiply`, these two models can be exported successfully with perf met. The original PR pytorch#57708 has merging issue, use this one instead. Test Plan: Imported from OSS Reviewed By: driazati Differential Revision: D28714809 Pulled By: SplitInfinity fbshipit-source-id: 71c2de6cec7ee05af68560996acf47d97af46fb2 Co-authored-by: David <jiafa@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is a fix for exporting fairseq models, see:
With this fix, and comment out model script one line
GradMultiply, these two models can be exported successfully with perf met.The original PR #57708 has merging issue, use this one instead.
Co-authored-by: David jiafa@microsoft.com
Differential Revision: D28714809